<feed xmlns='http://www.w3.org/2005/Atom'>
<title>netbsd/sys/opencrypto, branch trunk</title>
<subtitle>NetBSD fork for lockdoc analysis</subtitle>
<link rel='alternate' type='text/html' href='http://git.infra.scholz.ruhr/netbsd/'/>
<entry>
<title>fix misspellings of 'available' and nearby typos</title>
<updated>2022-09-10T12:14:17+00:00</updated>
<author>
<name>rillig</name>
<email>rillig@NetBSD.org</email>
</author>
<published>2022-09-10T12:14:17+00:00</published>
<link rel='alternate' type='text/html' href='http://git.infra.scholz.ruhr/netbsd/commit/?id=8af81c8ed049759872808d7e9d86e41eb1f22c16'/>
<id>8af81c8ed049759872808d7e9d86e41eb1f22c16</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>opencrypto(9): Fix missing initialization in error branch.</title>
<updated>2022-06-26T22:52:30+00:00</updated>
<author>
<name>riastradh</name>
<email>riastradh@NetBSD.org</email>
</author>
<published>2022-06-26T22:52:30+00:00</published>
<link rel='alternate' type='text/html' href='http://git.infra.scholz.ruhr/netbsd/commit/?id=30f5279af5f2ce75377a541f16430befc4d28ff9'/>
<id>30f5279af5f2ce75377a541f16430befc4d28ff9</id>
<content type='text'>
Reported-by: syzbot+8c519140cac567be1ee1@syzkaller.appspotmail.com</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Reported-by: syzbot+8c519140cac567be1ee1@syzkaller.appspotmail.com</pre>
</div>
</content>
</entry>
<entry>
<title>opencrypto: Assert session id is valid in crypto_freesession.</title>
<updated>2022-05-22T11:40:54+00:00</updated>
<author>
<name>riastradh</name>
<email>riastradh@NetBSD.org</email>
</author>
<published>2022-05-22T11:40:54+00:00</published>
<link rel='alternate' type='text/html' href='http://git.infra.scholz.ruhr/netbsd/commit/?id=301a4c55eb75848c351e944a98184294a9e63a30'/>
<id>301a4c55eb75848c351e944a98184294a9e63a30</id>
<content type='text'>
This gives us the opportunity to detect usage mistakes like
use-after-free.

Exception: Continue to silently ignore sid=0.</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This gives us the opportunity to detect usage mistakes like
use-after-free.

Exception: Continue to silently ignore sid=0.</pre>
</div>
</content>
</entry>
<entry>
<title>opencrypto: Prune dead code now that crypto_dispatch never fails.</title>
<updated>2022-05-22T11:40:38+00:00</updated>
<author>
<name>riastradh</name>
<email>riastradh@NetBSD.org</email>
</author>
<published>2022-05-22T11:40:38+00:00</published>
<link rel='alternate' type='text/html' href='http://git.infra.scholz.ruhr/netbsd/commit/?id=2654ab64609a515bfd8f58ac18602d39442bacc7'/>
<id>2654ab64609a515bfd8f58ac18602d39442bacc7</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>opencrypto: crypto_dispatch never fails now.  Make it return void.</title>
<updated>2022-05-22T11:40:29+00:00</updated>
<author>
<name>riastradh</name>
<email>riastradh@NetBSD.org</email>
</author>
<published>2022-05-22T11:40:29+00:00</published>
<link rel='alternate' type='text/html' href='http://git.infra.scholz.ruhr/netbsd/commit/?id=97a48304ff0aba3fc7292ecf0b39685dc75801e7'/>
<id>97a48304ff0aba3fc7292ecf0b39685dc75801e7</id>
<content type='text'>
Same with crypto_kdispatch.</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Same with crypto_kdispatch.</pre>
</div>
</content>
</entry>
<entry>
<title>opencrypto: Assert driver process routine returns 0 or ERESTART.</title>
<updated>2022-05-22T11:40:15+00:00</updated>
<author>
<name>riastradh</name>
<email>riastradh@NetBSD.org</email>
</author>
<published>2022-05-22T11:40:15+00:00</published>
<link rel='alternate' type='text/html' href='http://git.infra.scholz.ruhr/netbsd/commit/?id=e28eb32049a4627a449ae60b3eb01b49b34578d5'/>
<id>e28eb32049a4627a449ae60b3eb01b49b34578d5</id>
<content type='text'>
No other errors are allowed -- other errors must be transmitted by
crypto_done.  All drivers in tree (sun8i_crypto, glxsb, via_padlock,
mvcesa, mvxpsec, hifn, qat, ubsec, cryptosoft) have been audited for
this.</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
No other errors are allowed -- other errors must be transmitted by
crypto_done.  All drivers in tree (sun8i_crypto, glxsb, via_padlock,
mvcesa, mvxpsec, hifn, qat, ubsec, cryptosoft) have been audited for
this.</pre>
</div>
</content>
</entry>
<entry>
<title>opencrypto: Rip out EAGAIN logic when unregistering crypto drivers.</title>
<updated>2022-05-22T11:40:03+00:00</updated>
<author>
<name>riastradh</name>
<email>riastradh@NetBSD.org</email>
</author>
<published>2022-05-22T11:40:03+00:00</published>
<link rel='alternate' type='text/html' href='http://git.infra.scholz.ruhr/netbsd/commit/?id=e551848a610c4f86473cae62adbc842f4e446e6f'/>
<id>e551848a610c4f86473cae62adbc842f4e446e6f</id>
<content type='text'>
I'm pretty sure this never worked reliably based on code inspection,
and it's unlikely to have ever been tested because it only applies
when unregistering a driver -- but we have no crypto drivers for
removable devices, so it would only apply if we went out of our way
to trigger detach with drvctl.

Instead, just make the operation fail with ENODEV, and remove all the
callback logic to resubmit the request on EAGAIN.  (Maybe this should
be ENXIO, but crypto_kdispatch already does ENODEV.)</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
I'm pretty sure this never worked reliably based on code inspection,
and it's unlikely to have ever been tested because it only applies
when unregistering a driver -- but we have no crypto drivers for
removable devices, so it would only apply if we went out of our way
to trigger detach with drvctl.

Instead, just make the operation fail with ENODEV, and remove all the
callback logic to resubmit the request on EAGAIN.  (Maybe this should
be ENXIO, but crypto_kdispatch already does ENODEV.)</pre>
</div>
</content>
</entry>
<entry>
<title>opencrypto: Assert nonnull callback up front in crypto_dispatch.</title>
<updated>2022-05-22T11:39:54+00:00</updated>
<author>
<name>riastradh</name>
<email>riastradh@NetBSD.org</email>
</author>
<published>2022-05-22T11:39:54+00:00</published>
<link rel='alternate' type='text/html' href='http://git.infra.scholz.ruhr/netbsd/commit/?id=b546167f902315f9d15a0ac5b531e7985fb9314a'/>
<id>b546167f902315f9d15a0ac5b531e7985fb9314a</id>
<content type='text'>
Same with crypto_kdispatch.

Convert some dead branches downstream to assertions too.</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Same with crypto_kdispatch.

Convert some dead branches downstream to assertions too.</pre>
</div>
</content>
</entry>
<entry>
<title>crypto(4): Nix dead code now that crypto_freesession never fails.</title>
<updated>2022-05-22T11:39:45+00:00</updated>
<author>
<name>riastradh</name>
<email>riastradh@NetBSD.org</email>
</author>
<published>2022-05-22T11:39:45+00:00</published>
<link rel='alternate' type='text/html' href='http://git.infra.scholz.ruhr/netbsd/commit/?id=b47d9e92af6d5dab6821a51918f717695cbfa34d'/>
<id>b47d9e92af6d5dab6821a51918f717695cbfa34d</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>opencrypto: Make crypto_freesession return void.</title>
<updated>2022-05-22T11:39:37+00:00</updated>
<author>
<name>riastradh</name>
<email>riastradh@NetBSD.org</email>
</author>
<published>2022-05-22T11:39:37+00:00</published>
<link rel='alternate' type='text/html' href='http://git.infra.scholz.ruhr/netbsd/commit/?id=486410f45b32dfc76071c65f649d2734b7609852'/>
<id>486410f45b32dfc76071c65f649d2734b7609852</id>
<content type='text'>
No callers use the return value.  It is not sensible to allow this to
fail.</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
No callers use the return value.  It is not sensible to allow this to
fail.</pre>
</div>
</content>
</entry>
</feed>
