diff options
| author | joerg <joerg@NetBSD.org> | 2014-02-27 17:25:28 +0000 |
|---|---|---|
| committer | joerg <joerg@NetBSD.org> | 2014-02-27 17:25:28 +0000 |
| commit | 159abb8f74fe70bc2f1a40990740b81029cbb052 (patch) | |
| tree | 9e82d229941ee059cd3b7cf10229afd6ace43853 /tests/lib/libc/stdlib | |
| parent | a72e818c019ba57ef6532c025aa1acc12913fa09 (diff) | |
Don't use integer downcasts, use correctly sized constants for each test.
Diffstat (limited to 'tests/lib/libc/stdlib')
| -rw-r--r-- | tests/lib/libc/stdlib/t_abs.c | 52 |
1 files changed, 35 insertions, 17 deletions
diff --git a/tests/lib/libc/stdlib/t_abs.c b/tests/lib/libc/stdlib/t_abs.c index 218c652a7bd..43ce55b30bc 100644 --- a/tests/lib/libc/stdlib/t_abs.c +++ b/tests/lib/libc/stdlib/t_abs.c @@ -1,4 +1,4 @@ -/* $NetBSD: t_abs.c,v 1.1 2012/03/29 06:16:56 jruoho Exp $ */ +/* $NetBSD: t_abs.c,v 1.2 2014/02/27 17:25:28 joerg Exp $ */ /*- * Copyright (c) 2012 The NetBSD Foundation, Inc. @@ -29,18 +29,13 @@ * POSSIBILITY OF SUCH DAMAGE. */ #include <sys/cdefs.h> -__RCSID("$NetBSD: t_abs.c,v 1.1 2012/03/29 06:16:56 jruoho Exp $"); +__RCSID("$NetBSD: t_abs.c,v 1.2 2014/02/27 17:25:28 joerg Exp $"); #include <atf-c.h> #include <inttypes.h> #include <limits.h> #include <stdlib.h> -struct test { - int64_t val; - int64_t res; -}; - ATF_TC(abs_basic); ATF_TC_HEAD(abs_basic, tc) { @@ -49,7 +44,10 @@ ATF_TC_HEAD(abs_basic, tc) ATF_TC_BODY(abs_basic, tc) { - static const struct test table[] = { + static const struct { + int val; + int res; + } table[] = { { 0, 0 }, { +0, 0 }, { -0, 0 }, @@ -59,7 +57,7 @@ ATF_TC_BODY(abs_basic, tc) }; for (size_t i = 0; i < __arraycount(table); i++) - ATF_CHECK(abs(table[i].val) == (int)table[i].res); + ATF_CHECK(abs(table[i].val) == table[i].res); } ATF_TC(imaxabs_basic); @@ -70,14 +68,23 @@ ATF_TC_HEAD(imaxabs_basic, tc) ATF_TC_BODY(imaxabs_basic, tc) { - static const struct test table[] = { + static const struct { + intmax_t val; + intmax_t res; + } table[] = { { 0, 0 }, { INT_MAX, INT_MAX }, { -INT_MAX, INT_MAX }, + { LONG_MAX, LONG_MAX }, + { -LONG_MAX, LONG_MAX }, + { LLONG_MAX, LLONG_MAX }, + { -LLONG_MAX, LLONG_MAX }, + { INT_MAX, INT_MAX }, + { -INT_MAX, INT_MAX }, }; for (size_t i = 0; i < __arraycount(table); i++) - ATF_CHECK(imaxabs(table[i].val) == (intmax_t)table[i].res); + ATF_CHECK(imaxabs(table[i].val) == table[i].res); } ATF_TC(labs_basic); @@ -88,18 +95,22 @@ ATF_TC_HEAD(labs_basic, tc) ATF_TC_BODY(labs_basic, tc) { - static const struct test table[] = { + static const struct { + long val; + long res; + } table[] = { { 0, 0 }, { +0, 0 }, { -0, 0 }, { -1, 1 }, { LONG_MAX, LONG_MAX }, { -LONG_MAX, LONG_MAX }, - { -0x100000000, 0x100000000 }, + { INT_MAX, INT_MAX }, + { -INT_MAX, -INT_MAX }, }; for (size_t i = 0; i < __arraycount(table); i++) - ATF_CHECK(labs(table[i].val) == (long int)table[i].res); + ATF_CHECK(labs(table[i].val) == table[i].res); } ATF_TC(llabs_basic); @@ -110,18 +121,25 @@ ATF_TC_HEAD(llabs_basic, tc) ATF_TC_BODY(llabs_basic, tc) { - static const struct test table[] = { + static const struct { + long long val; + long long res; + } table[] = { { 0, 0 }, { +0, 0 }, { -0, 0 }, { -1, 1 }, + { INT_MAX, INT_MAX }, + { -INT_MAX, INT_MAX }, + { LONG_MAX, LONG_MAX }, + { -LONG_MAX, LONG_MAX }, { LLONG_MAX, LLONG_MAX }, { -LLONG_MAX, LLONG_MAX }, - { -0x100000000, 0x100000000 }, + { -0x100000000LL, 0x100000000LL }, }; for (size_t i = 0; i < __arraycount(table); i++) - ATF_CHECK(llabs(table[i].val) == (long long int)table[i].res); + ATF_CHECK(llabs(table[i].val) == table[i].res); } ATF_TP_ADD_TCS(tp) |
