From b7fa3afd42a567bc28b2a2c71b60d606531b94b1 Mon Sep 17 00:00:00 2001 From: maxv Date: Sat, 24 Aug 2019 12:33:25 +0000 Subject: Don't read data from userland directly. This simply does not work on any recent x86 CPU (thanks to SMAP) and all architectures that forbid direct access to userland from the kernel. But I guess no one noticed because no one ever uses compat_linux, right? --- sys/compat/linux/common/linux_socket.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'sys/compat/linux/common/linux_socket.h') diff --git a/sys/compat/linux/common/linux_socket.h b/sys/compat/linux/common/linux_socket.h index 3b14fd15ef5..336c9c288cc 100644 --- a/sys/compat/linux/common/linux_socket.h +++ b/sys/compat/linux/common/linux_socket.h @@ -1,4 +1,4 @@ -/* $NetBSD: linux_socket.h,v 1.23 2017/02/03 16:57:39 christos Exp $ */ +/* $NetBSD: linux_socket.h,v 1.24 2019/08/24 12:33:25 maxv Exp $ */ /*- * Copyright (c) 1995, 1998 The NetBSD Foundation, Inc. @@ -186,13 +186,13 @@ struct linux_cmsghdr { /* Linux either uses this, or &((cmsg)->__cmsg_data) */ #define LINUX_CMSG_DATA(cmsg) \ ((u_char *)((struct linux_cmsghdr *)(cmsg) + 1)) -#define LINUX_CMSG_NXTHDR(mhdr, cmsg) \ - ((((char *)(cmsg) + LINUX_CMSG_ALIGN((cmsg)->cmsg_len) + \ - sizeof(*(cmsg))) > \ +#define LINUX_CMSG_NXTHDR(mhdr, ucmsg, kcmsg) \ + ((((char *)(ucmsg) + LINUX_CMSG_ALIGN((kcmsg)->cmsg_len) + \ + sizeof(*(ucmsg))) > \ (((char *)(mhdr)->msg_control) + (mhdr)->msg_controllen)) ? \ (struct linux_cmsghdr *)NULL : \ - (struct linux_cmsghdr *)((char *)(cmsg) + \ - LINUX_CMSG_ALIGN((cmsg)->cmsg_len))) + (struct linux_cmsghdr *)((char *)(ucmsg) + \ + LINUX_CMSG_ALIGN((kcmsg)->cmsg_len))) /* This the number of bytes removed from each item (excl. final padding) */ #define LINUX_CMSG_ALIGN_DELTA \ (CMSG_ALIGN(sizeof(struct cmsghdr)) - sizeof(struct linux_cmsghdr)) -- cgit