From 5b0334cb548083ee3e9beb34d51fd9a8c5df8759 Mon Sep 17 00:00:00 2001 From: riastradh Date: Mon, 28 Mar 2022 12:37:35 +0000 Subject: specfs: Assert opencnt is nonzero before decrementing. --- sys/miscfs/specfs/spec_vnops.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'sys/miscfs') diff --git a/sys/miscfs/specfs/spec_vnops.c b/sys/miscfs/specfs/spec_vnops.c index 109785a176b..0df5a57b3ca 100644 --- a/sys/miscfs/specfs/spec_vnops.c +++ b/sys/miscfs/specfs/spec_vnops.c @@ -1,4 +1,4 @@ -/* $NetBSD: spec_vnops.c,v 1.206 2022/03/28 12:37:26 riastradh Exp $ */ +/* $NetBSD: spec_vnops.c,v 1.207 2022/03/28 12:37:35 riastradh Exp $ */ /*- * Copyright (c) 2008 The NetBSD Foundation, Inc. @@ -58,7 +58,7 @@ */ #include -__KERNEL_RCSID(0, "$NetBSD: spec_vnops.c,v 1.206 2022/03/28 12:37:26 riastradh Exp $"); +__KERNEL_RCSID(0, "$NetBSD: spec_vnops.c,v 1.207 2022/03/28 12:37:35 riastradh Exp $"); #include #include @@ -944,6 +944,8 @@ spec_open(void *v) KASSERT(sn->sn_opencnt == 1); needclose = true; } else { + KASSERT(sd->sd_opencnt); + KASSERT(sn->sn_opencnt); sd->sd_opencnt--; sn->sn_opencnt--; if (vp->v_type == VBLK) @@ -1643,6 +1645,8 @@ spec_close(void *v) * between open and close can use fd_clone. */ mutex_enter(&device_lock); + KASSERT(sn->sn_opencnt); + KASSERT(sd->sd_opencnt); sn->sn_opencnt--; count = --sd->sd_opencnt; if (vp->v_type == VBLK) { -- cgit