summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorshm <shm@NetBSD.org>2015-08-09 09:39:21 +0000
committershm <shm@NetBSD.org>2015-08-09 09:39:21 +0000
commit240fab7705ed38fda17332ea765af55c8fae533d (patch)
tree728f8fc48578685df21d24d386c9dd95f6510d9a
parentd3bfee14317d391ad30284cfd678bea1f2925e1b (diff)
Do not use pamh after pam_end. It's cosmetic change since pam_strerror
ignores that parameter.
-rw-r--r--usr.bin/su/su_pam.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/usr.bin/su/su_pam.c b/usr.bin/su/su_pam.c
index 70a3f5ac114..9ac7a7c64d0 100644
--- a/usr.bin/su/su_pam.c
+++ b/usr.bin/su/su_pam.c
@@ -1,4 +1,4 @@
-/* $NetBSD: su_pam.c,v 1.19 2013/06/29 05:08:35 mlelstv Exp $ */
+/* $NetBSD: su_pam.c,v 1.20 2015/08/09 09:39:21 shm Exp $ */
/*
* Copyright (c) 1988 The Regents of the University of California.
@@ -39,7 +39,7 @@ __COPYRIGHT("@(#) Copyright (c) 1988\
#if 0
static char sccsid[] = "@(#)su.c 8.3 (Berkeley) 4/2/94";*/
#else
-__RCSID("$NetBSD: su_pam.c,v 1.19 2013/06/29 05:08:35 mlelstv Exp $");
+__RCSID("$NetBSD: su_pam.c,v 1.20 2015/08/09 09:39:21 shm Exp $");
#endif
#endif /* not lint */
@@ -253,7 +253,7 @@ main(int argc, char **argv)
syslog(LOG_WARNING, "BAD SU %s to %s%s: %s",
username, user, ontty(), safe_pam_strerror(pamh, pam_err));
(void)pam_end(pamh, pam_err);
- errx(EXIT_FAILURE, "Sorry: %s", safe_pam_strerror(pamh, pam_err));
+ errx(EXIT_FAILURE, "Sorry: %s", safe_pam_strerror(NULL, pam_err));
}
/*
ass='logsubject'>Rename slightly misleading KTHREAD_JOINABLE to KTHREAD_MUSTJOIN.rmind 2011-06-22fix an operator precedence error picked up by GCC 4.5.3. real bug.mrg 2010-12-01Don't bother asserting: if we create the thread without KTHREAD_MPSAFE,pooka it's not going to be MPSAFE. 2010-11-15Make interface support ifconfig {down,destroy} and generally makepooka it a little less eager to panic. 2010-10-19Make virtif a cloner so that it can be brough to life also withpooka "ifconfig create". As previously, virt<n> interfaces with the host's /dev/tap<n> (I guess it could be made explicit with "ifconfig media", but leave it this way for now). 2010-08-10* improve diagnostic printpooka * deal with a tap quirk when it returns 0 bytes 2010-04-05Fix typojoerg 2010-04-05Push the bpf_ops usage back into bpf.h. Push the common ifp->if_bpfjoerg check into the inline functions as well the fourth argument for bpf_attach. 2010-03-01Introduce RUMP_COMPONENT. It behaves mostly like a simplifiedpooka module which is linked into the kernel and cannot be unloaded. The main purpose is to get the proper constructors run and create any /dev nodes necessary for said component. Once more of the kernel (e.g. networking stack and device drivers) are converted to MODULE and devfs pops up from somewhere, rump components can be retired. 2010-01-19Redefine bpf linkage through an always present op vector, i.e.pooka #if NBPFILTER is no longer required in the client. This change doesn't yet add support for loading bpf as a module, since drivers can register before bpf is attached. However, callers of bpf can now be modularized. Dynamically loadable bpf could probably be done fairly easily with coordination from the stub driver and the real driver by registering attachments in the stub before the real driver is loaded and doing a handoff. ... and I'm not going to ponder the depths of unload here. Tested with i386/MONOLITHIC, modified MONOLITHIC without bpf and rump. 2010-01-16support bpfpooka 2009-10-14"rumppriv" goes back to "rump" per internal interface naming change.pooka 2009-10-14Adjust rump sources for external/internal interfaces.pooka No functional change. 2009-10-12Bump iovec lazy bum magic value to 32: nfsd likes to write mbufspooka with 17 per chain (previous i'm-too-lazy-for-my-forloop value was of course 16). 2009-09-16work around tap bug: if /dev/tap<n> was previously non-blocking, newlypooka opened fd's will also be non-blocking. (yeayea, i'll fix the kernel some day, but I don't want to reboot my host OS now) 2009-05-28Use a bunch of weak symbols to determine which network componentspooka are present. This works in userspace as opposed relying in link sets, which fail miserably. Later, when the networking stack becomes modularized, we can move to a dynamic scheme like with file systems. Also, this change allows us to do proper autoconfig, namely attach the loopback interface iff it is present. 2009-05-27Add a dummyif, which doesn't actually traffic any cargo, but sincepooka it has no backend it can always be attached and is therefore convenient for testing ifconfig. 2009-05-26Filter out ENETRESET from ether_ioctl() since we aren't interestedpooka in multicast hugging. 2009-03-27* make interface creation open /dev/tapn for interface npooka * create "unique" enaddr * do send in async context 2009-02-28Fix a silly mistake: indubitably the struct ifnet pointer given topooka ether_ifattach() should point to a struct ethercom. 2009-02-26decouple from host struct iovecpooka 2008-12-18__KERNEL_RCSIDpooka 2008-10-16Add a prototype to allow this to build (will be moved to a betterpooka place later). 2008-10-16kill default DBG=-gpooka 2008-10-14Make the "something random" ethernet address ETHER_IS_LOCALpooka (address assignment probably needs some more work if we want to support multiple interfaces). hat tip to Quentin Garnier 2008-10-13Dear diary: an ethernet address with 0x01 set in the first octetpooka is an ethernet multicast address. TCP does not like ethernet multicast addresses. 2008-10-06Implement a virtual userspace networking interface. This is requiredpooka for any sensible operation when running the entire TCP/IP stack in userspace (as opposed to libsockin which uses host kernel networking to provide PF_INET). While this basically works (although it is quite barebones), it depends on some bit of cleanup in librump and is not built by default yet.