diff options
| author | mlelstv <mlelstv@NetBSD.org> | 2020-02-10 22:33:28 +0000 |
|---|---|---|
| committer | mlelstv <mlelstv@NetBSD.org> | 2020-02-10 22:33:28 +0000 |
| commit | f5fbbb435982fdb1eab8ac81a10d4e95c5dc6f04 (patch) | |
| tree | 4ceb8a61d02e931ac6a5780ff16126773f6ac064 | |
| parent | f2497ac3b6e9995d82d49e52e9f554ec13aa8702 (diff) | |
Don't use strlcpy to copy untrusted input, it may not be NUL-terminated.
| -rw-r--r-- | sys/compat/netbsd32/netbsd32_ioctl.c | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/sys/compat/netbsd32/netbsd32_ioctl.c b/sys/compat/netbsd32/netbsd32_ioctl.c index 2667a525b1b..1aec8842e77 100644 --- a/sys/compat/netbsd32/netbsd32_ioctl.c +++ b/sys/compat/netbsd32/netbsd32_ioctl.c @@ -1,4 +1,4 @@ -/* $NetBSD: netbsd32_ioctl.c,v 1.107 2020/02/01 02:23:03 riastradh Exp $ */ +/* $NetBSD: netbsd32_ioctl.c,v 1.108 2020/02/10 22:33:28 mlelstv Exp $ */ /* * Copyright (c) 1998, 2001 Matthew R. Green @@ -31,7 +31,7 @@ */ #include <sys/cdefs.h> -__KERNEL_RCSID(0, "$NetBSD: netbsd32_ioctl.c,v 1.107 2020/02/01 02:23:03 riastradh Exp $"); +__KERNEL_RCSID(0, "$NetBSD: netbsd32_ioctl.c,v 1.108 2020/02/10 22:33:28 mlelstv Exp $"); #if defined(_KERNEL_OPT) #include "opt_ntp.h" @@ -147,7 +147,7 @@ netbsd32_to_if_addrprefreq(const struct netbsd32_if_addrprefreq *ifap32, struct if_addrprefreq *ifap, u_long cmd) { - strlcpy(ifap->ifap_name, ifap32->ifap_name, sizeof(ifap->ifap_name)); + memcpy(ifap->ifap_name, ifap32->ifap_name, IFNAMSIZ+1); ifap->ifap_preference = ifap32->ifap_preference; memcpy(&ifap->ifap_addr, &ifap32->ifap_addr, uimin(ifap32->ifap_addr.ss_len, _SS_MAXSIZE)); @@ -386,7 +386,7 @@ netbsd32_to_ieee80211req(struct netbsd32_ieee80211req *ireq32, struct ieee80211req *ireq, u_long cmd) { - strlcpy(ireq->i_name, ireq32->i_name, IFNAMSIZ); + memcpy(ireq->i_name, ireq32->i_name, IFNAMSIZ); ireq->i_type = ireq32->i_type; ireq->i_val = ireq32->i_val; ireq->i_len = ireq32->i_len; @@ -399,7 +399,7 @@ netbsd32_to_ieee80211_nwkey(struct netbsd32_ieee80211_nwkey *nwk32, { int i; - strlcpy(nwk->i_name, nwk32->i_name, IFNAMSIZ); + memcpy(nwk->i_name, nwk32->i_name, IFNAMSIZ); nwk->i_wepon = nwk32->i_wepon; nwk->i_defkid = nwk32->i_defkid; for (i = 0; i < IEEE80211_WEP_NKID; i++) { @@ -630,7 +630,7 @@ netbsd32_from_if_addrprefreq(const struct if_addrprefreq *ifap, struct netbsd32_if_addrprefreq *ifap32, u_long cmd) { - strlcpy(ifap32->ifap_name, ifap->ifap_name, sizeof(ifap32->ifap_name)); + memcpy(ifap32->ifap_name, ifap->ifap_name, IFNAMSIZ); ifap32->ifap_preference = ifap->ifap_preference; memcpy(&ifap32->ifap_addr, &ifap->ifap_addr, uimin(ifap->ifap_addr.ss_len, _SS_MAXSIZE)); @@ -865,7 +865,7 @@ netbsd32_from_ieee80211req(struct ieee80211req *ireq, struct netbsd32_ieee80211req *ireq32, u_long cmd) { - strlcpy(ireq32->i_name, ireq->i_name, IFNAMSIZ); + memcpy(ireq32->i_name, ireq->i_name, IFNAMSIZ); ireq32->i_type = ireq->i_type; ireq32->i_val = ireq->i_val; ireq32->i_len = ireq->i_len; @@ -878,7 +878,7 @@ netbsd32_from_ieee80211_nwkey(struct ieee80211_nwkey *nwk, { int i; - strlcpy(nwk32->i_name, nwk->i_name, IFNAMSIZ); + memcpy(nwk32->i_name, nwk->i_name, IFNAMSIZ); nwk32->i_wepon = nwk->i_wepon; nwk32->i_defkid = nwk->i_defkid; for (i = 0; i < IEEE80211_WEP_NKID; i++) { |
