summaryrefslogtreecommitdiff
path: root/common/lib/libc/string/consttime_memequal.c
diff options
context:
space:
mode:
authorriastradh <riastradh@NetBSD.org>2013-08-28 15:24:41 +0000
committerriastradh <riastradh@NetBSD.org>2013-08-28 15:24:41 +0000
commitbb1d12db8a8adebb626f9db549d429a14a964832 (patch)
tree7985a24cf84b4efdae237d3e3124760f5a44547f /common/lib/libc/string/consttime_memequal.c
parenta454fa8ec73dcbe9f5d629a35f6eef562b14f41a (diff)
Fix sense of consttime_memequal and update all callers.
Now it returns true (nonzero) to mean equal and false (zero) to mean inequal, as the name suggests. As promised on tech-userlevel back in June: https://mail-index.netbsd.org/tech-userlevel/2013/06/24/msg007843.html
Diffstat (limited to 'common/lib/libc/string/consttime_memequal.c')
-rw-r--r--common/lib/libc/string/consttime_memequal.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/common/lib/libc/string/consttime_memequal.c b/common/lib/libc/string/consttime_memequal.c
index 969e53295fe..795cd822d70 100644
--- a/common/lib/libc/string/consttime_memequal.c
+++ b/common/lib/libc/string/consttime_memequal.c
@@ -1,4 +1,4 @@
-/* $NetBSD: consttime_memequal.c,v 1.1 2013/06/24 04:21:19 riastradh Exp $ */
+/* $NetBSD: consttime_memequal.c,v 1.2 2013/08/28 15:24:41 riastradh Exp $ */
#if !defined(_KERNEL) && !defined(_STANDALONE)
#include <string.h>
@@ -15,5 +15,5 @@ consttime_memequal(const void *b1, const void *b2, size_t len)
while (len --)
res |= *c1++ ^ *c2++;
- return res;
+ return !res;
}