diff options
| author | fox <fox@NetBSD.org> | 2020-06-12 01:20:32 +0000 |
|---|---|---|
| committer | fox <fox@NetBSD.org> | 2020-06-12 01:20:32 +0000 |
| commit | 6b1c4b2f0432ba515c4af02b7df355a935e76637 (patch) | |
| tree | 3db601cb0bbc68c1f12b6c77fe44485187d638b6 /lib/libpam | |
| parent | a885d03b3a5ebd1b4450737b26af00151ac5167c (diff) | |
lib/libpam: Fix the possible -Werror=stringop-truncation
Replace strncpy(3) with the safer strlcpy(3) and adjust the code.
Error was reported when build.sh was run with MKLIBCSANITIZER=yes flag.
Reviewed by: kamil@, christos@
Diffstat (limited to 'lib/libpam')
| -rw-r--r-- | lib/libpam/modules/pam_krb5/pam_krb5.c | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/lib/libpam/modules/pam_krb5/pam_krb5.c b/lib/libpam/modules/pam_krb5/pam_krb5.c index 0d98ae48196..42e13f991fd 100644 --- a/lib/libpam/modules/pam_krb5/pam_krb5.c +++ b/lib/libpam/modules/pam_krb5/pam_krb5.c @@ -1,4 +1,4 @@ -/* $NetBSD: pam_krb5.c,v 1.28 2020/02/07 23:28:59 christos Exp $ */ +/* $NetBSD: pam_krb5.c,v 1.29 2020/06/12 01:20:32 fox Exp $ */ /*- * This pam_krb5 module contains code that is: @@ -53,7 +53,7 @@ #ifdef __FreeBSD__ __FBSDID("$FreeBSD: src/lib/libpam/modules/pam_krb5/pam_krb5.c,v 1.22 2005/01/24 16:49:50 rwatson Exp $"); #else -__RCSID("$NetBSD: pam_krb5.c,v 1.28 2020/02/07 23:28:59 christos Exp $"); +__RCSID("$NetBSD: pam_krb5.c,v 1.29 2020/06/12 01:20:32 fox Exp $"); #endif #include <sys/types.h> @@ -945,9 +945,8 @@ verify_krb_v5_tgt(krb5_context context, krb5_ccache ccache, return -1; /* Extract the name directly. */ - strncpy(phost, compat_princ_component(context, princ, 1), - BUFSIZ); - phost[BUFSIZ - 1] = '\0'; + strlcpy(phost, compat_princ_component(context, princ, 1), + sizeof(phost)); /* * Do we have service/<host> keys? |
