summaryrefslogtreecommitdiff
path: root/share
diff options
context:
space:
mode:
authorrillig <rillig@NetBSD.org>2023-04-14 16:53:13 +0000
committerrillig <rillig@NetBSD.org>2023-04-14 16:53:13 +0000
commit87aa81dce71aa596fe0ca8605e96e2013cd477fa (patch)
treeed17098ec8a7283d17f59f8cb77c0af23ffd4fcf /share
parent245f5e21b00b8f2e9c0046b7574ec11dbfa3dd6d (diff)
style: don't require sorting variables in functions
Sorting the variables by size would be platform-dependent and thus is not possible. Sorting the variables alphabetically may or may not make the code easier to read, and the example given below that rule doesn't follow it, otherwise the correct order would be 'eight, eleven, nine, ten, thirteen, twelve'. https://mail-index.netbsd.org/tech-userlevel/2023/04/11/msg013749.html
Diffstat (limited to 'share')
-rw-r--r--share/misc/style10
1 files changed, 5 insertions, 5 deletions
diff --git a/share/misc/style b/share/misc/style
index 367e6602a68..45fef7697c4 100644
--- a/share/misc/style
+++ b/share/misc/style
@@ -1,4 +1,4 @@
-/* $NetBSD: style,v 1.70 2023/04/11 14:22:10 riastradh Exp $ */
+/* $NetBSD: style,v 1.71 2023/04/14 16:53:13 rillig Exp $ */
/*
* The revision control tag appears first, with a blank line after it.
@@ -30,7 +30,7 @@
#include <sys/cdefs.h>
__COPYRIGHT("@(#) Copyright (c) 2008\
The NetBSD Foundation, inc. All rights reserved.");
-__RCSID("$NetBSD: style,v 1.70 2023/04/11 14:22:10 riastradh Exp $");
+__RCSID("$NetBSD: style,v 1.71 2023/04/14 16:53:13 rillig Exp $");
/*
* VERY important single-line comments look like this.
@@ -353,10 +353,10 @@ static char *
function(int a1, int a2, float fl, int a4)
{
/*
- * When declaring variables in functions declare them sorted by size,
- * then in alphabetical order; multiple ones per line are okay.
+ * When declaring variables in functions, multiple variables per line
+ * are okay. If a line overflows reuse the type keyword.
+ *
* Function prototypes should go in the include file "extern.h".
- * If a line overflows reuse the type keyword.
*
* Avoid initializing variables in the declarations; move
* declarations next to their first use, and initialize