diff options
| author | tsutsui <tsutsui@NetBSD.org> | 2022-06-25 22:38:43 +0000 |
|---|---|---|
| committer | tsutsui <tsutsui@NetBSD.org> | 2022-06-25 22:38:43 +0000 |
| commit | 2105c30e6ce60d63a7e9dc6e7b6069ff6f4a1f02 (patch) | |
| tree | 6650537039626a9100c0474fbe2798b8c1fe0190 /sys/arch/atari | |
| parent | dbeeeb3af6abd8a3eb0acc73cccd2019429f8c2b (diff) | |
No need to print errors via aprint_error(9) in probe/match function.
Note aprint_error(9) triggers "WARNING: 1 error while detecting hardware"
message after device configuration, so it's a bit confusing for users.
Also check all possible variants even if bus_space_map(9) fails
(though now it shouldn't fail).
Diffstat (limited to 'sys/arch/atari')
| -rw-r--r-- | sys/arch/atari/vme/if_le_vme.c | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/sys/arch/atari/vme/if_le_vme.c b/sys/arch/atari/vme/if_le_vme.c index c2ab2eadff3..a39c66cbf59 100644 --- a/sys/arch/atari/vme/if_le_vme.c +++ b/sys/arch/atari/vme/if_le_vme.c @@ -1,4 +1,4 @@ -/* $NetBSD: if_le_vme.c,v 1.32 2022/06/25 22:31:09 tsutsui Exp $ */ +/* $NetBSD: if_le_vme.c,v 1.33 2022/06/25 22:38:43 tsutsui Exp $ */ /*- * Copyright (c) 1998 maximum entropy. All rights reserved. @@ -74,7 +74,7 @@ */ #include <sys/cdefs.h> -__KERNEL_RCSID(0, "$NetBSD: if_le_vme.c,v 1.32 2022/06/25 22:31:09 tsutsui Exp $"); +__KERNEL_RCSID(0, "$NetBSD: if_le_vme.c,v 1.33 2022/06/25 22:38:43 tsutsui Exp $"); #include "opt_inet.h" @@ -233,8 +233,7 @@ le_vme_match(device_t parent, cfdata_t cfp, void *aux) if (bus_space_map(iot, le_ap->reg_addr, le_ap->reg_size, 0, &ioh)) { - aprint_error("leprobe: cannot map io-area\n"); - return 0; + continue; } if (le_ap->mem_size == VMECF_MEMSIZ_DEFAULT) { if (bvme410_probe(iot, ioh)) { @@ -252,8 +251,7 @@ le_vme_match(device_t parent, cfdata_t cfp, void *aux) if (bus_space_map(memt, le_ap->mem_addr, le_ap->mem_size, 0, &memh)) { bus_space_unmap(iot, ioh, le_ap->reg_size); - aprint_error("leprobe: cannot map memory-area\n"); - return 0; + continue; } found = probe_addresses(&iot, &memt, &ioh, &memh); bus_space_unmap(iot, ioh, le_ap->reg_size); |
