diff options
| author | pavel <pavel@NetBSD.org> | 2006-09-25 16:16:18 +0000 |
|---|---|---|
| committer | pavel <pavel@NetBSD.org> | 2006-09-25 16:16:18 +0000 |
| commit | 3cdb79bdae4837fe917b42e60395a4f6eaaecc73 (patch) | |
| tree | d3508d7b22edb99025fce702a3845f7a83b79bd5 /sys/compat/linux/common/linux_file.c | |
| parent | c43e654c14baeb3e2b42d3d6f963f1e0aba659ec (diff) | |
Replace homegrown tests for FIFO (... & S_IFIFO) by S_ISFIFO. The old code
was "correct" by luck - we don't have any other file type whose S_IF* bits
in sys/stat.h overlap with S_IFIFO.
Originally discovered by Paul Stoeber in OpenBSD.
Diffstat (limited to 'sys/compat/linux/common/linux_file.c')
| -rw-r--r-- | sys/compat/linux/common/linux_file.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/sys/compat/linux/common/linux_file.c b/sys/compat/linux/common/linux_file.c index 76cf197a540..32e3bfe77c7 100644 --- a/sys/compat/linux/common/linux_file.c +++ b/sys/compat/linux/common/linux_file.c @@ -1,4 +1,4 @@ -/* $NetBSD: linux_file.c,v 1.73 2006/07/23 22:06:09 ad Exp $ */ +/* $NetBSD: linux_file.c,v 1.74 2006/09/25 16:16:18 pavel Exp $ */ /*- * Copyright (c) 1995, 1998 The NetBSD Foundation, Inc. @@ -42,7 +42,7 @@ */ #include <sys/cdefs.h> -__KERNEL_RCSID(0, "$NetBSD: linux_file.c,v 1.73 2006/07/23 22:06:09 ad Exp $"); +__KERNEL_RCSID(0, "$NetBSD: linux_file.c,v 1.74 2006/09/25 16:16:18 pavel Exp $"); #include <sys/param.h> #include <sys/systm.h> @@ -737,7 +737,7 @@ linux_sys_mknod(l, v, retval) /* * BSD handles FIFOs separately */ - if (SCARG(uap, mode) & S_IFIFO) { + if (S_ISFIFO(SCARG(uap, mode))) { struct sys_mkfifo_args bma; SCARG(&bma, path) = SCARG(uap, path); |
