diff options
| author | tkusumi <tkusumi@NetBSD.org> | 2019-12-21 11:59:03 +0000 |
|---|---|---|
| committer | tkusumi <tkusumi@NetBSD.org> | 2019-12-21 11:59:03 +0000 |
| commit | 87d1de18f98b3e78b5d086567959f7431f8fc42a (patch) | |
| tree | 3d1f4c2ef558d31594cae4d74558e53cc1bf680c /sys/dev/dm/dm_target_error.c | |
| parent | 7a94ebcb188dcd4da56810d8d5686b9cacac2127 (diff) | |
dm: Remove target's ->deps() by implementing deps in dm core
Retrieving device dependencies doesn't need to be target specific.
The reason it currently needs ->deps() is because dm core doesn't
have data structure that allows table to walk through target's
underlying devices. Add struct dm_mapping to be able to do this,
and remove ->deps()'s from targets which basically do the same thing.
=====(A) before this commit
table
| [dm core]
-------------------------------------------------------
| pdev pdev pdev [dm targets]
v ^ ^ ^
target----/---------/---------/
(void*)
=====(B) this commit
table---->mapping-->mapping-->mapping-->...
| | | |
| v v v [dm core]
-------------------------------------------------------
| pdev pdev pdev [dm targets]
v ^ ^ ^
target----/---------/---------/
(void*)
taken-from: DragonFlyBSD
Diffstat (limited to 'sys/dev/dm/dm_target_error.c')
| -rw-r--r-- | sys/dev/dm/dm_target_error.c | 13 |
1 files changed, 2 insertions, 11 deletions
diff --git a/sys/dev/dm/dm_target_error.c b/sys/dev/dm/dm_target_error.c index 511a5b7fe2f..888c9ea898e 100644 --- a/sys/dev/dm/dm_target_error.c +++ b/sys/dev/dm/dm_target_error.c @@ -1,4 +1,4 @@ -/* $NetBSD: dm_target_error.c,v 1.26 2019/12/18 14:31:35 tkusumi Exp $ */ +/* $NetBSD: dm_target_error.c,v 1.27 2019/12/21 11:59:03 tkusumi Exp $ */ /* * Copyright (c) 2008 The NetBSD Foundation, Inc. @@ -29,7 +29,7 @@ * POSSIBILITY OF SUCH DAMAGE. */ #include <sys/cdefs.h> -__KERNEL_RCSID(0, "$NetBSD: dm_target_error.c,v 1.26 2019/12/18 14:31:35 tkusumi Exp $"); +__KERNEL_RCSID(0, "$NetBSD: dm_target_error.c,v 1.27 2019/12/21 11:59:03 tkusumi Exp $"); /* * This file implements initial version of device-mapper error target. @@ -73,7 +73,6 @@ dm_target_error_modcmd(modcmd_t cmd, void *arg) dmt->init = &dm_target_error_init; dmt->table = &dm_target_error_table; dmt->strategy = &dm_target_error_strategy; - dmt->deps = &dm_target_error_deps; dmt->destroy = &dm_target_error_destroy; dmt->upcall = &dm_target_error_upcall; @@ -145,14 +144,6 @@ dm_target_error_destroy(dm_table_entry_t *table_en) return 0; } -/* Doesn't not need to do anything here. */ -int -dm_target_error_deps(dm_table_entry_t *table_en, prop_array_t prop_array) -{ - - return 0; -} - /* Unsupported for this target. */ int dm_target_error_upcall(dm_table_entry_t *table_en, struct buf *bp) |
