summaryrefslogtreecommitdiff
path: root/sys/dev/dm/dm_target_snapshot.c
diff options
context:
space:
mode:
authoragc <agc@NetBSD.org>2014-08-18 17:16:19 +0000
committeragc <agc@NetBSD.org>2014-08-18 17:16:19 +0000
commitb0cd2b186b069d41c213ec6f76e75d0bc07efc82 (patch)
treebd053f68e69cbf91bf916c3ed5ab67d3b98c590f /sys/dev/dm/dm_target_snapshot.c
parenta4f89ee965930d022c3381918c9a1b2f6f08113b (diff)
Avoid a memory leak - from maxv
Diffstat (limited to 'sys/dev/dm/dm_target_snapshot.c')
-rw-r--r--sys/dev/dm/dm_target_snapshot.c9
1 files changed, 5 insertions, 4 deletions
diff --git a/sys/dev/dm/dm_target_snapshot.c b/sys/dev/dm/dm_target_snapshot.c
index 685e94ac6f3..0ac23397c70 100644
--- a/sys/dev/dm/dm_target_snapshot.c
+++ b/sys/dev/dm/dm_target_snapshot.c
@@ -1,4 +1,4 @@
-/* $NetBSD: dm_target_snapshot.c,v 1.16 2014/06/14 07:39:00 hannken Exp $ */
+/* $NetBSD: dm_target_snapshot.c,v 1.17 2014/08/18 17:16:19 agc Exp $ */
/*
* Copyright (c) 2008 The NetBSD Foundation, Inc.
@@ -221,8 +221,7 @@ dm_target_snapshot_init(dm_dev_t * dmv, void **target_config, char *params)
if ((dmp_snap = dm_pdev_insert(argv[0])) == NULL)
return ENOENT;
- if ((tsc = kmem_alloc(sizeof(dm_target_snapshot_config_t), KM_NOSLEEP))
- == NULL)
+ if ((tsc = kmem_alloc(sizeof(*tsc), KM_NOSLEEP)) == NULL)
return 1;
tsc->tsc_persistent_dev = 0;
@@ -232,8 +231,10 @@ dm_target_snapshot_init(dm_dev_t * dmv, void **target_config, char *params)
tsc->tsc_persistent_dev = 1;
/* Insert cow device to global pdev list */
- if ((dmp_cow = dm_pdev_insert(argv[1])) == NULL)
+ if ((dmp_cow = dm_pdev_insert(argv[1])) == NULL) {
+ kmem_free(tsc, sizeof(*tsc));
return ENOENT;
+ }
}
tsc->tsc_chunk_size = atoi(argv[3]);