summaryrefslogtreecommitdiff
path: root/sys/dev/hdaudio
diff options
context:
space:
mode:
authorkhorben <khorben@NetBSD.org>2018-01-04 00:09:12 +0000
committerkhorben <khorben@NetBSD.org>2018-01-04 00:09:12 +0000
commit4e883f97bf37e07ffa3bef762789e90190c50abe (patch)
treeffde5196e1281c94b6e7acd31847370da87b6f69 /sys/dev/hdaudio
parent84973b70e0ab64e91ee21b082bf01f085633db8e (diff)
Fix off-by-one when calling snprintf(9) in hdafg_getdev()
This is actually harmless, since: - the offset is too short rather than too long (no overflow) - the struct audio_device comes from userland (no information leak) "looks good to me" nat@
Diffstat (limited to 'sys/dev/hdaudio')
-rw-r--r--sys/dev/hdaudio/hdafg.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/sys/dev/hdaudio/hdafg.c b/sys/dev/hdaudio/hdafg.c
index 267c7b002a5..301cb30cda9 100644
--- a/sys/dev/hdaudio/hdafg.c
+++ b/sys/dev/hdaudio/hdafg.c
@@ -1,4 +1,4 @@
-/* $NetBSD: hdafg.c,v 1.13 2017/08/04 00:25:23 mrg Exp $ */
+/* $NetBSD: hdafg.c,v 1.14 2018/01/04 00:09:12 khorben Exp $ */
/*
* Copyright (c) 2009 Precedence Technologies Ltd <support@precedence.co.uk>
@@ -60,7 +60,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: hdafg.c,v 1.13 2017/08/04 00:25:23 mrg Exp $");
+__KERNEL_RCSID(0, "$NetBSD: hdafg.c,v 1.14 2018/01/04 00:09:12 khorben Exp $");
#include <sys/types.h>
#include <sys/param.h>
@@ -4058,7 +4058,7 @@ hdafg_getdev(void *opaque, struct audio_device *audiodev)
sc->sc_vendor);
hdaudio_findproduct(audiodev->version, sizeof(audiodev->version),
sc->sc_vendor, sc->sc_product);
- snprintf(audiodev->config, sizeof(audiodev->config) - 1,
+ snprintf(audiodev->config, sizeof(audiodev->config),
"%02Xh", sc->sc_nid);
return 0;