diff options
| author | ad <ad@NetBSD.org> | 2006-09-07 01:03:02 +0000 |
|---|---|---|
| committer | ad <ad@NetBSD.org> | 2006-09-07 01:03:02 +0000 |
| commit | 5c5838e6908a66b135f8575cc29b2a42402eada3 (patch) | |
| tree | 9f88ef3ca96fc6e30623d4196172ec0990ed7e9c /sys/dev/lockstat.c | |
| parent | 297f4619292f00872a0cfa7b61b24f9882471224 (diff) | |
- Add a couple of XXX comments.
- lb->lb_cpu doesn't need to be filled in lockstat_event().
Diffstat (limited to 'sys/dev/lockstat.c')
| -rw-r--r-- | sys/dev/lockstat.c | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/sys/dev/lockstat.c b/sys/dev/lockstat.c index 97dd91ae3d1..1e6a2560188 100644 --- a/sys/dev/lockstat.c +++ b/sys/dev/lockstat.c @@ -1,4 +1,4 @@ -/* $NetBSD: lockstat.c,v 1.1 2006/09/07 00:20:28 ad Exp $ */ +/* $NetBSD: lockstat.c,v 1.2 2006/09/07 01:03:02 ad Exp $ */ /*- * Copyright (c) 2006 The NetBSD Foundation, Inc. @@ -42,7 +42,7 @@ */ #include <sys/cdefs.h> -__KERNEL_RCSID(0, "$NetBSD: lockstat.c,v 1.1 2006/09/07 00:20:28 ad Exp $"); +__KERNEL_RCSID(0, "$NetBSD: lockstat.c,v 1.2 2006/09/07 01:03:02 ad Exp $"); #include <sys/types.h> #include <sys/param.h> @@ -240,7 +240,7 @@ lockstat_start(lsenable_t *le) lockstat_lockaddr = le->le_lock; /* - * Force a write barrier. + * Force a write barrier. XXX This may not be sufficient.. */ lockstat_unlock(0); tsleep(&lockstat_start, PPAUSE, "lockstat", mstohz(10)); @@ -268,7 +268,7 @@ lockstat_stop(lsdisable_t *ld) /* * Set enabled false, force a write barrier, and wait for other CPUs - * to exit lockstat_event(). + * to exit lockstat_event(). XXX This may not be sufficient.. */ lockstat_enabled = 0; lockstat_unlock(0); @@ -411,7 +411,6 @@ lockstat_event(uintptr_t lock, uintptr_t callsite, u_int flags, u_int count, SLIST_REMOVE_HEAD(&lc->lc_free, lb_chain.slist); LIST_INSERT_HEAD(ll, lb, lb_chain.list); lb->lb_flags = (uint16_t)flags; - lb->lb_cpu = (uint16_t)cpu_number(); lb->lb_lock = lock; lb->lb_callsite = callsite; lb->lb_counts[event] = count; |
