diff options
| author | ad <ad@NetBSD.org> | 2007-07-29 12:15:35 +0000 |
|---|---|---|
| committer | ad <ad@NetBSD.org> | 2007-07-29 12:15:35 +0000 |
| commit | 66fefd117bcf82d547bfa88ca68a5b43f17a7103 (patch) | |
| tree | 6344a9f4cbb126386fe0895fb71a9fab75c81aa6 /sys/dev/ofw/ofdisk.c | |
| parent | 480f8d26c5a97f0c8620ae2e36349bfc462ca19c (diff) | |
It's not a good idea for device drivers to modify b_flags, as they don't
need to understand the locking around that field. Instead of setting
B_ERROR, set b_error instead. b_error is 'owned' by whoever completes
the I/O request.
Diffstat (limited to 'sys/dev/ofw/ofdisk.c')
| -rw-r--r-- | sys/dev/ofw/ofdisk.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/sys/dev/ofw/ofdisk.c b/sys/dev/ofw/ofdisk.c index 2ccc56bd1ae..0c1988b825e 100644 --- a/sys/dev/ofw/ofdisk.c +++ b/sys/dev/ofw/ofdisk.c @@ -1,4 +1,4 @@ -/* $NetBSD: ofdisk.c,v 1.36 2007/07/21 19:51:48 ad Exp $ */ +/* $NetBSD: ofdisk.c,v 1.37 2007/07/29 12:15:43 ad Exp $ */ /* * Copyright (C) 1995, 1996 Wolfgang Solfrank. @@ -32,7 +32,7 @@ */ #include <sys/cdefs.h> -__KERNEL_RCSID(0, "$NetBSD: ofdisk.c,v 1.36 2007/07/21 19:51:48 ad Exp $"); +__KERNEL_RCSID(0, "$NetBSD: ofdisk.c,v 1.37 2007/07/29 12:15:43 ad Exp $"); #include <sys/param.h> #include <sys/buf.h> @@ -301,7 +301,6 @@ ofdisk_strategy(struct buf *bp) if (read < 0) { bp->b_error = EIO; - bp->b_flags |= B_ERROR; bp->b_resid = bp->b_bcount; } else bp->b_resid = bp->b_bcount - read; |
