summaryrefslogtreecommitdiff
path: root/sys/dev/usb
diff options
context:
space:
mode:
authormycroft <mycroft@NetBSD.org>2004-06-22 18:27:46 +0000
committermycroft <mycroft@NetBSD.org>2004-06-22 18:27:46 +0000
commit7c3a6504d02ef95aaeee100511ed128e8aec3756 (patch)
tree614de4f2e5eb80a00de94aea842e52acf71b4fa0 /sys/dev/usb
parent3c9aef7cc5c354cfb21a46beec78639d8d0d493e (diff)
Adjust a couple of comments to make it clear WTF is going on.
Diffstat (limited to 'sys/dev/usb')
-rw-r--r--sys/dev/usb/ehci.c14
-rw-r--r--sys/dev/usb/ohci.c7
2 files changed, 8 insertions, 13 deletions
diff --git a/sys/dev/usb/ehci.c b/sys/dev/usb/ehci.c
index 957f59642ef..44f57e9acbd 100644
--- a/sys/dev/usb/ehci.c
+++ b/sys/dev/usb/ehci.c
@@ -1,4 +1,4 @@
-/* $NetBSD: ehci.c,v 1.61 2004/06/22 18:05:18 mycroft Exp $ */
+/* $NetBSD: ehci.c,v 1.62 2004/06/22 18:27:46 mycroft Exp $ */
/*
* Copyright (c) 2004 The NetBSD Foundation, Inc.
@@ -65,7 +65,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: ehci.c,v 1.61 2004/06/22 18:05:18 mycroft Exp $");
+__KERNEL_RCSID(0, "$NetBSD: ehci.c,v 1.62 2004/06/22 18:27:46 mycroft Exp $");
#include "ohci.h"
#include "uhci.h"
@@ -2521,14 +2521,8 @@ ehci_device_request(usbd_xfer_handle xfer)
sqh = epipe->sqh;
epipe->u.ctl.length = len;
- /* XXX
- * Since we're messing with the QH we must know the HC is in sync.
- * This needs to go away since it slows down control transfers.
- * Removing it entails:
- * - fill the QH only once with addr & wMaxPacketSize
- */
- /* ehci_sync_hc(sc); */
- /* Update device address and length since they may have changed. */
+ /* Update device address and length since they may have changed
+ during the setup of the control pipe in usbd_new_device(). */
/* XXX This only needs to be done once, but it's too early in open. */
/* XXXX Should not touch ED here! */
sqh->qh.qh_endp =
diff --git a/sys/dev/usb/ohci.c b/sys/dev/usb/ohci.c
index 56a402fa020..9ccae6815c8 100644
--- a/sys/dev/usb/ohci.c
+++ b/sys/dev/usb/ohci.c
@@ -1,4 +1,4 @@
-/* $NetBSD: ohci.c,v 1.147 2004/06/22 07:20:35 mycroft Exp $ */
+/* $NetBSD: ohci.c,v 1.148 2004/06/22 18:27:46 mycroft Exp $ */
/* $FreeBSD: src/sys/dev/usb/ohci.c,v 1.22 1999/11/17 22:33:40 n_hibma Exp $ */
/*
@@ -46,7 +46,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: ohci.c,v 1.147 2004/06/22 07:20:35 mycroft Exp $");
+__KERNEL_RCSID(0, "$NetBSD: ohci.c,v 1.148 2004/06/22 18:27:46 mycroft Exp $");
#include <sys/param.h>
#include <sys/systm.h>
@@ -1668,7 +1668,8 @@ ohci_device_request(usbd_xfer_handle xfer)
sed = opipe->sed;
opipe->u.ctl.length = len;
- /* Update device address and length since they may have changed. */
+ /* Update device address and length since they may have changed
+ during the setup of the control pipe in usbd_new_device(). */
/* XXX This only needs to be done once, but it's too early in open. */
/* XXXX Should not touch ED here! */
sed->ed.ed_flags = htole32(