diff options
| author | msaitoh <msaitoh@NetBSD.org> | 2019-12-01 08:16:49 +0000 |
|---|---|---|
| committer | msaitoh <msaitoh@NetBSD.org> | 2019-12-01 08:16:49 +0000 |
| commit | 30cdd8de4b5e2d123995a907d31eae0b62ccf0ad (patch) | |
| tree | c2341c7d8be1d57cfc3c3a60b9b6e4afb3d6c887 /sys/dev | |
| parent | fcf5cf8bf4dee58980cf689c8270eee393a0169a (diff) | |
Use unsigned to avoid undefined behavoir. Found by kUBSan.
Diffstat (limited to 'sys/dev')
| -rw-r--r-- | sys/dev/pci/if_age.c | 6 | ||||
| -rw-r--r-- | sys/dev/pci/if_alc.c | 4 | ||||
| -rw-r--r-- | sys/dev/pci/if_ale.c | 6 |
3 files changed, 8 insertions, 8 deletions
diff --git a/sys/dev/pci/if_age.c b/sys/dev/pci/if_age.c index 0ff00d6ce77..2f33e2625ed 100644 --- a/sys/dev/pci/if_age.c +++ b/sys/dev/pci/if_age.c @@ -1,4 +1,4 @@ -/* $NetBSD: if_age.c,v 1.64 2019/11/21 09:12:30 msaitoh Exp $ */ +/* $NetBSD: if_age.c,v 1.65 2019/12/01 08:16:49 msaitoh Exp $ */ /* $OpenBSD: if_age.c,v 1.1 2009/01/16 05:00:34 kevlo Exp $ */ /*- @@ -31,7 +31,7 @@ /* Driver for Attansic Technology Corp. L1 Gigabit Ethernet. */ #include <sys/cdefs.h> -__KERNEL_RCSID(0, "$NetBSD: if_age.c,v 1.64 2019/11/21 09:12:30 msaitoh Exp $"); +__KERNEL_RCSID(0, "$NetBSD: if_age.c,v 1.65 2019/12/01 08:16:49 msaitoh Exp $"); #include "vlan.h" @@ -2291,7 +2291,7 @@ age_rxfilter(struct age_softc *sc) goto update; } crc = ether_crc32_be(enm->enm_addrlo, ETHER_ADDR_LEN); - mchash[crc >> 31] |= 1 << ((crc >> 26) & 0x1f); + mchash[crc >> 31] |= 1U << ((crc >> 26) & 0x1f); ETHER_NEXT_MULTI(step, enm); } ETHER_UNLOCK(ec); diff --git a/sys/dev/pci/if_alc.c b/sys/dev/pci/if_alc.c index af108999764..0f486d09afa 100644 --- a/sys/dev/pci/if_alc.c +++ b/sys/dev/pci/if_alc.c @@ -1,4 +1,4 @@ -/* $NetBSD: if_alc.c,v 1.44 2019/11/21 09:12:30 msaitoh Exp $ */ +/* $NetBSD: if_alc.c,v 1.45 2019/12/01 08:16:49 msaitoh Exp $ */ /* $OpenBSD: if_alc.c,v 1.1 2009/08/08 09:31:13 kevlo Exp $ */ /*- * Copyright (c) 2009, Pyun YongHyeon <yongari@FreeBSD.org> @@ -3459,7 +3459,7 @@ alc_iff(struct alc_softc *sc) goto update; } crc = ether_crc32_be(enm->enm_addrlo, ETHER_ADDR_LEN); - mchash[crc >> 31] |= 1 << ((crc >> 26) & 0x1f); + mchash[crc >> 31] |= 1U << ((crc >> 26) & 0x1f); ETHER_NEXT_MULTI(step, enm); } ETHER_UNLOCK(ec); diff --git a/sys/dev/pci/if_ale.c b/sys/dev/pci/if_ale.c index 68cfe85f48b..3ebeb1e82cc 100644 --- a/sys/dev/pci/if_ale.c +++ b/sys/dev/pci/if_ale.c @@ -1,4 +1,4 @@ -/* $NetBSD: if_ale.c,v 1.36 2019/11/21 09:18:16 msaitoh Exp $ */ +/* $NetBSD: if_ale.c,v 1.37 2019/12/01 08:16:49 msaitoh Exp $ */ /*- * Copyright (c) 2008, Pyun YongHyeon <yongari@FreeBSD.org> @@ -32,7 +32,7 @@ /* Driver for Atheros AR8121/AR8113/AR8114 PCIe Ethernet. */ #include <sys/cdefs.h> -__KERNEL_RCSID(0, "$NetBSD: if_ale.c,v 1.36 2019/11/21 09:18:16 msaitoh Exp $"); +__KERNEL_RCSID(0, "$NetBSD: if_ale.c,v 1.37 2019/12/01 08:16:49 msaitoh Exp $"); #include "vlan.h" @@ -2012,7 +2012,7 @@ ale_rxfilter(struct ale_softc *sc) goto update; } crc = ether_crc32_be(enm->enm_addrlo, ETHER_ADDR_LEN); - mchash[crc >> 31] |= 1 << ((crc >> 26) & 0x1f); + mchash[crc >> 31] |= 1U << ((crc >> 26) & 0x1f); ETHER_NEXT_MULTI(step, enm); } ETHER_UNLOCK(ec); |
