summaryrefslogtreecommitdiff
path: root/sys/dev
diff options
context:
space:
mode:
authorriastradh <riastradh@NetBSD.org>2019-12-06 03:45:33 +0000
committerriastradh <riastradh@NetBSD.org>2019-12-06 03:45:33 +0000
commit54cd576007c25bf915a07cc47e1a9dd8ff6a6fcf (patch)
tree201aaf6b6dc45f90f48889897f9bb368a82d7932 /sys/dev
parentca17814744c0a8590a66f709f09b2ddcca06e253 (diff)
Fix reference count leak in cons(4).
Don't forget to vrele after you're done, folks! XXX pullup-9 XXX pullup-8 XXX pullup-7 XXX pullup-6... 5... 4 might not have had this bug!
Diffstat (limited to 'sys/dev')
-rw-r--r--sys/dev/cons.c7
1 files changed, 4 insertions, 3 deletions
diff --git a/sys/dev/cons.c b/sys/dev/cons.c
index 09a85fe875b..2217ebfdc13 100644
--- a/sys/dev/cons.c
+++ b/sys/dev/cons.c
@@ -1,4 +1,4 @@
-/* $NetBSD: cons.c,v 1.75 2015/05/29 16:26:45 macallan Exp $ */
+/* $NetBSD: cons.c,v 1.76 2019/12/06 03:45:33 riastradh Exp $ */
/*
* Copyright (c) 1988 University of Utah.
@@ -33,13 +33,13 @@
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*
- * from: Utah $Hdr: cons.c 1.7 92/01/21$
+ * from: Utah $Hdr$
*
* @(#)cons.c 8.2 (Berkeley) 1/12/94
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: cons.c,v 1.75 2015/05/29 16:26:45 macallan Exp $");
+__KERNEL_RCSID(0, "$NetBSD: cons.c,v 1.76 2019/12/06 03:45:33 riastradh Exp $");
#include <sys/param.h>
#include <sys/proc.h>
@@ -158,6 +158,7 @@ cnclose(dev_t dev, int flag, int mode, struct lwp *l)
if (error == 0) {
error = VOP_CLOSE(vp, flag, kauth_cred_get());
VOP_UNLOCK(vp);
+ vrele(vp);
}
return error;
}