summaryrefslogtreecommitdiff
path: root/sys/dev
diff options
context:
space:
mode:
authorriastradh <riastradh@NetBSD.org>2022-03-03 05:55:38 +0000
committerriastradh <riastradh@NetBSD.org>2022-03-03 05:55:38 +0000
commita0a4ae2e888be3ffd00291b55a6fd26de5dee955 (patch)
tree5874bde7756e594f571680430c011eb5fb840c74 /sys/dev
parent09fba8a14fdec95b46e03e0b9c2a0efe1ae3f64c (diff)
usbnet drivers: Omit redundant device reset via *_uno_stop on init.
Only those drivers where *_uno_stop is just *_reset, and *_uno_init immediately calls *_reset afterward, are affected.
Diffstat (limited to 'sys/dev')
-rw-r--r--sys/dev/usb/if_axe.c7
-rw-r--r--sys/dev/usb/if_mos.c7
-rw-r--r--sys/dev/usb/if_smsc.c7
3 files changed, 6 insertions, 15 deletions
diff --git a/sys/dev/usb/if_axe.c b/sys/dev/usb/if_axe.c
index d9c38ad3bba..c95307fe15d 100644
--- a/sys/dev/usb/if_axe.c
+++ b/sys/dev/usb/if_axe.c
@@ -1,4 +1,4 @@
-/* $NetBSD: if_axe.c,v 1.147 2022/03/03 05:55:29 riastradh Exp $ */
+/* $NetBSD: if_axe.c,v 1.148 2022/03/03 05:55:38 riastradh Exp $ */
/* $OpenBSD: if_axe.c,v 1.137 2016/04/13 11:03:37 mpi Exp $ */
/*
@@ -87,7 +87,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_axe.c,v 1.147 2022/03/03 05:55:29 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_axe.c,v 1.148 2022/03/03 05:55:38 riastradh Exp $");
#ifdef _KERNEL_OPT
#include "opt_usb.h"
@@ -1211,9 +1211,6 @@ axe_uno_init(struct ifnet *ifp)
struct axe_softc * const sc = usbnet_softc(un);
int rxmode;
- /* Cancel pending I/O */
- axe_uno_stop(ifp, 1);
-
/* Reset the ethernet interface. */
axe_reset(un);
diff --git a/sys/dev/usb/if_mos.c b/sys/dev/usb/if_mos.c
index d2b371b412f..432d7ca87bc 100644
--- a/sys/dev/usb/if_mos.c
+++ b/sys/dev/usb/if_mos.c
@@ -1,4 +1,4 @@
-/* $NetBSD: if_mos.c,v 1.19 2022/03/03 05:55:29 riastradh Exp $ */
+/* $NetBSD: if_mos.c,v 1.20 2022/03/03 05:55:38 riastradh Exp $ */
/* $OpenBSD: if_mos.c,v 1.40 2019/07/07 06:40:10 kevlo Exp $ */
/*
@@ -72,7 +72,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_mos.c,v 1.19 2022/03/03 05:55:29 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_mos.c,v 1.20 2022/03/03 05:55:38 riastradh Exp $");
#include <sys/param.h>
@@ -732,9 +732,6 @@ mos_uno_init(struct ifnet *ifp)
u_int8_t rxmode;
unsigned char ipgs[2];
- /* Cancel pending I/O */
- mos_uno_stop(ifp, 1);
-
/* Reset the ethernet interface. */
mos_reset(un);
diff --git a/sys/dev/usb/if_smsc.c b/sys/dev/usb/if_smsc.c
index 78b485339f3..c24ae308f3d 100644
--- a/sys/dev/usb/if_smsc.c
+++ b/sys/dev/usb/if_smsc.c
@@ -1,4 +1,4 @@
-/* $NetBSD: if_smsc.c,v 1.89 2022/03/03 05:55:29 riastradh Exp $ */
+/* $NetBSD: if_smsc.c,v 1.90 2022/03/03 05:55:38 riastradh Exp $ */
/* $OpenBSD: if_smsc.c,v 1.4 2012/09/27 12:38:11 jsg Exp $ */
/* $FreeBSD: src/sys/dev/usb/net/if_smsc.c,v 1.1 2012/08/15 04:03:55 gonzo Exp $ */
@@ -61,7 +61,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_smsc.c,v 1.89 2022/03/03 05:55:29 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_smsc.c,v 1.90 2022/03/03 05:55:38 riastradh Exp $");
#ifdef _KERNEL_OPT
#include "opt_usb.h"
@@ -555,9 +555,6 @@ smsc_uno_init(struct ifnet *ifp)
struct usbnet * const un = ifp->if_softc;
struct smsc_softc * const sc = usbnet_softc(un);
- /* Cancel pending I/O */
- smsc_uno_stop(ifp, 1);
-
/* Reset the ethernet interface. */
smsc_reset(sc);