summaryrefslogtreecommitdiff
path: root/sys/dev
diff options
context:
space:
mode:
authorriastradh <riastradh@NetBSD.org>2022-03-03 06:22:40 +0000
committerriastradh <riastradh@NetBSD.org>2022-03-03 06:22:40 +0000
commita831c19b3af7485c11699486fab617721d3d2015 (patch)
tree83d36b3cadabf158cfe1043d129368939b23ecdc /sys/dev
parent1019f4f85c98dccb7e47c23321a900a8d716efd5 (diff)
uvideo(4): Fix zero initialization of uvideo_stream.
Just use kmem_zalloc; don't memset it to zero, especially not after we just inserted it into the list, with the side effect of deleting the rest of the list!
Diffstat (limited to 'sys/dev')
-rw-r--r--sys/dev/usb/uvideo.c7
1 files changed, 3 insertions, 4 deletions
diff --git a/sys/dev/usb/uvideo.c b/sys/dev/usb/uvideo.c
index 3144801688d..aa3ccc403e4 100644
--- a/sys/dev/usb/uvideo.c
+++ b/sys/dev/usb/uvideo.c
@@ -1,4 +1,4 @@
-/* $NetBSD: uvideo.c,v 1.66 2022/03/03 06:22:03 riastradh Exp $ */
+/* $NetBSD: uvideo.c,v 1.67 2022/03/03 06:22:40 riastradh Exp $ */
/*
* Copyright (c) 2008 Patrick Mahoney
@@ -42,7 +42,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: uvideo.c,v 1.66 2022/03/03 06:22:03 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: uvideo.c,v 1.67 2022/03/03 06:22:40 riastradh Exp $");
#ifdef _KERNEL_OPT
#include "opt_usb.h"
@@ -752,7 +752,7 @@ uvideo_stream_guess_format(struct uvideo_stream *vs,
static struct uvideo_stream *
uvideo_stream_alloc(void)
{
- return kmem_alloc(sizeof(struct uvideo_stream), KM_SLEEP);
+ return kmem_zalloc(sizeof(struct uvideo_stream), KM_SLEEP);
}
@@ -1031,7 +1031,6 @@ uvideo_stream_init(struct uvideo_stream *vs,
vs));
SLIST_INSERT_HEAD(&sc->sc_stream_list, vs, entries);
- memset(vs, 0, sizeof(*vs));
vs->vs_parent = sc;
vs->vs_ifaceno = ifdesc->bInterfaceNumber;
vs->vs_subtype = 0;