summaryrefslogtreecommitdiff
path: root/sys/dev
diff options
context:
space:
mode:
authorbouyer <bouyer@NetBSD.org>2012-03-06 18:29:23 +0000
committerbouyer <bouyer@NetBSD.org>2012-03-06 18:29:23 +0000
commitd9e498ef9c9b351ff186007b883e33e08eb77dc5 (patch)
tree8a1201d599d4d1d7d2a0eb1e68e164db8602f602 /sys/dev
parent95d2797764f41a007b92ec829126e4b236276fa3 (diff)
bnx_start() is not MP-safe, so do not create the bnx_alloc_pkts()'s
workqueue MPSAFE. This could lead to bnx_start() being running at the same time on 2 CPUs, with packets being sent twice. Problem found and reported by Beverly Schwartz and Greg Troxel.
Diffstat (limited to 'sys/dev')
-rw-r--r--sys/dev/pci/if_bnx.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/sys/dev/pci/if_bnx.c b/sys/dev/pci/if_bnx.c
index 7ee5905d076..5ab778260a6 100644
--- a/sys/dev/pci/if_bnx.c
+++ b/sys/dev/pci/if_bnx.c
@@ -1,4 +1,4 @@
-/* $NetBSD: if_bnx.c,v 1.45 2011/09/22 08:42:53 jym Exp $ */
+/* $NetBSD: if_bnx.c,v 1.46 2012/03/06 18:29:23 bouyer Exp $ */
/* $OpenBSD: if_bnx.c,v 1.85 2009/11/09 14:32:41 dlg Exp $ */
/*-
@@ -35,7 +35,7 @@
#if 0
__FBSDID("$FreeBSD: src/sys/dev/bce/if_bce.c,v 1.3 2006/04/13 14:12:26 ru Exp $");
#endif
-__KERNEL_RCSID(0, "$NetBSD: if_bnx.c,v 1.45 2011/09/22 08:42:53 jym Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_bnx.c,v 1.46 2012/03/06 18:29:23 bouyer Exp $");
/*
* The following controllers are supported by this driver:
@@ -707,7 +707,7 @@ bnx_attach(device_t parent, device_t self, void *aux)
/* create workqueue to handle packet allocations */
if (workqueue_create(&sc->bnx_wq, device_xname(self),
- bnx_alloc_pkts, sc, PRI_NONE, IPL_NET, WQ_MPSAFE) != 0) {
+ bnx_alloc_pkts, sc, PRI_NONE, IPL_NET, 0) != 0) {
aprint_error_dev(self, "failed to create workqueue\n");
goto bnx_attach_fail;
}