summaryrefslogtreecommitdiff
path: root/sys/dev
diff options
context:
space:
mode:
authorriastradh <riastradh@NetBSD.org>2022-08-20 14:08:17 +0000
committerriastradh <riastradh@NetBSD.org>2022-08-20 14:08:17 +0000
commitdcb3325607403f13b7bf03ee451e4b6aea608e1f (patch)
tree36b417b3540f5189defee14e2bc12b56e8ac5dca /sys/dev
parent1076e502e9a1d7753eed2ccf8c07a06e339df961 (diff)
usbnet(9): Simplify core lock use in usbnet_tick_task.
Diffstat (limited to 'sys/dev')
-rw-r--r--sys/dev/usb/usbnet.c8
1 files changed, 3 insertions, 5 deletions
diff --git a/sys/dev/usb/usbnet.c b/sys/dev/usb/usbnet.c
index 0dba4eea78d..534de11d392 100644
--- a/sys/dev/usb/usbnet.c
+++ b/sys/dev/usb/usbnet.c
@@ -1,4 +1,4 @@
-/* $NetBSD: usbnet.c,v 1.104 2022/08/20 14:08:05 riastradh Exp $ */
+/* $NetBSD: usbnet.c,v 1.105 2022/08/20 14:08:17 riastradh Exp $ */
/*
* Copyright (c) 2019 Matthew R. Green
@@ -31,7 +31,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: usbnet.c,v 1.104 2022/08/20 14:08:05 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: usbnet.c,v 1.105 2022/08/20 14:08:17 riastradh Exp $");
#include <sys/param.h>
#include <sys/kernel.h>
@@ -1237,16 +1237,14 @@ usbnet_tick_task(void *arg)
/* Call driver if requested. */
uno_tick(un);
+ mutex_enter(&unp->unp_core_lock);
DPRINTFN(8, "mii %#jx ifp %#jx", (uintptr_t)mii, (uintptr_t)ifp, 0, 0);
if (mii) {
- mutex_enter(&unp->unp_core_lock);
mii_tick(mii);
if (!unp->unp_link)
(*mii->mii_statchg)(ifp);
- mutex_exit(&unp->unp_core_lock);
}
- mutex_enter(&unp->unp_core_lock);
if (!unp->unp_stopped && !usbnet_isdying(un))
callout_schedule(&unp->unp_stat_ch, hz);
mutex_exit(&unp->unp_core_lock);