summaryrefslogtreecommitdiff
path: root/sys/dev
diff options
context:
space:
mode:
authormsaitoh <msaitoh@NetBSD.org>2022-08-08 07:49:18 +0000
committermsaitoh <msaitoh@NetBSD.org>2022-08-08 07:49:18 +0000
commitf4aa0cb3f387e643d189ea66d51471ee5e5d0537 (patch)
tree9e8dd234cf300ff6509b09b875097d63fc3b3666 /sys/dev
parentebfee705d2eabc954530bfd57c5693b27c04c1b8 (diff)
Pass an error code correctly if phy.acquire() failed.
This is not a real bug because the return value is not used.
Diffstat (limited to 'sys/dev')
-rw-r--r--sys/dev/pci/if_wm.c9
1 files changed, 5 insertions, 4 deletions
diff --git a/sys/dev/pci/if_wm.c b/sys/dev/pci/if_wm.c
index b6b6a306642..f9b096cd4fd 100644
--- a/sys/dev/pci/if_wm.c
+++ b/sys/dev/pci/if_wm.c
@@ -1,4 +1,4 @@
-/* $NetBSD: if_wm.c,v 1.754 2022/08/08 07:44:40 msaitoh Exp $ */
+/* $NetBSD: if_wm.c,v 1.755 2022/08/08 07:49:18 msaitoh Exp $ */
/*
* Copyright (c) 2001, 2002, 2003, 2004 Wasabi Systems, Inc.
@@ -82,7 +82,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_wm.c,v 1.754 2022/08/08 07:44:40 msaitoh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_wm.c,v 1.755 2022/08/08 07:49:18 msaitoh Exp $");
#ifdef _KERNEL_OPT
#include "opt_net_mpsafe.h"
@@ -16399,9 +16399,10 @@ wm_set_eee_pchlan(struct wm_softc *sc)
return 0;
}
- if (sc->phy.acquire(sc)) {
+ rv = sc->phy.acquire(sc);
+ if (rv != 0) {
device_printf(dev, "%s: failed to get semaphore\n", __func__);
- return 0;
+ return rv;
}
rv = sc->phy.readreg_locked(dev, 1, I82579_LPI_CTRL, &lpi_ctrl);