diff options
| author | riastradh <riastradh@NetBSD.org> | 2014-07-03 20:48:19 +0000 |
|---|---|---|
| committer | riastradh <riastradh@NetBSD.org> | 2014-07-03 20:48:19 +0000 |
| commit | b477aea84ecec41fe2e67143e960253b04aedbaa (patch) | |
| tree | 6a55f7dcb94793f6cf039ee7e1c2b21ab14ff5c4 /sys/external/bsd/common/include/linux/completion.h | |
| parent | 18c86dffd7da9a1c60c63d3a608d233310ffd80e (diff) | |
Add some notes on using these shims to port Linux kernel code.
Diffstat (limited to 'sys/external/bsd/common/include/linux/completion.h')
| -rw-r--r-- | sys/external/bsd/common/include/linux/completion.h | 16 |
1 files changed, 15 insertions, 1 deletions
diff --git a/sys/external/bsd/common/include/linux/completion.h b/sys/external/bsd/common/include/linux/completion.h index b41c451502d..bbb92902cda 100644 --- a/sys/external/bsd/common/include/linux/completion.h +++ b/sys/external/bsd/common/include/linux/completion.h @@ -1,4 +1,4 @@ -/* $NetBSD: completion.h,v 1.3 2014/05/05 15:59:11 skrll Exp $ */ +/* $NetBSD: completion.h,v 1.4 2014/07/03 20:48:19 riastradh Exp $ */ /*- * Copyright (c) 2013 The NetBSD Foundation, Inc. @@ -29,6 +29,20 @@ * POSSIBILITY OF SUCH DAMAGE. */ +/* + * Notes on porting: + * + * - Linux does not have destroy_completion. You must add it yourself + * in the appropriate place. + * + * - Some Linux code does `completion->done++' or similar. Convert + * that to complete(completion) and suggest the same change upstream, + * unless it turns out there actually is a good reason to do that, in + * which case the Linux completion API should be extended with a + * sensible name for this that doesn't expose the guts of `struct + * completion'. + */ + #ifndef _LINUX_COMPLETION_H_ #define _LINUX_COMPLETION_H_ |
