diff options
| author | riastradh <riastradh@NetBSD.org> | 2022-05-21 20:37:18 +0000 |
|---|---|---|
| committer | riastradh <riastradh@NetBSD.org> | 2022-05-21 20:37:18 +0000 |
| commit | 06c944f0426ac69a2533ca5f4b54d25db567d354 (patch) | |
| tree | 4fb9db3bdfd5eec5d47018724f5460fb01eea0a5 /sys/opencrypto | |
| parent | 265dd290f8db6868cc00e0de0cea9796b6f3442a (diff) | |
crypto(4): Don't signal the condvar for multi-operation completion.
The condvar may be destroyed by the time we got here, and nothing
waits on it anyway -- instead the caller is expected to select/poll
for completion in userland.
The bug was already here, but the recent change to eliminate
CRYPTO_F_CBIMM made it happen more often by causing the callback to
_always_ be run asynchronously instead of sometimes being run
synchronously.
Diffstat (limited to 'sys/opencrypto')
| -rw-r--r-- | sys/opencrypto/cryptodev.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/sys/opencrypto/cryptodev.c b/sys/opencrypto/cryptodev.c index 45f6f2a684d..b05cba4fea5 100644 --- a/sys/opencrypto/cryptodev.c +++ b/sys/opencrypto/cryptodev.c @@ -1,4 +1,4 @@ -/* $NetBSD: cryptodev.c,v 1.113 2022/05/19 20:51:46 riastradh Exp $ */ +/* $NetBSD: cryptodev.c,v 1.114 2022/05/21 20:37:18 riastradh Exp $ */ /* $FreeBSD: src/sys/opencrypto/cryptodev.c,v 1.4.2.4 2003/06/03 00:09:02 sam Exp $ */ /* $OpenBSD: cryptodev.c,v 1.53 2002/07/10 22:21:30 mickey Exp $ */ @@ -64,7 +64,7 @@ */ #include <sys/cdefs.h> -__KERNEL_RCSID(0, "$NetBSD: cryptodev.c,v 1.113 2022/05/19 20:51:46 riastradh Exp $"); +__KERNEL_RCSID(0, "$NetBSD: cryptodev.c,v 1.114 2022/05/21 20:37:18 riastradh Exp $"); #include <sys/param.h> #include <sys/systm.h> @@ -746,9 +746,6 @@ cryptodev_mcb(struct cryptop *crp) error = crypto_dispatch(crp); mutex_enter(&cryptodev_mtx); } - if (error != 0 || (crp->crp_flags & CRYPTO_F_DONE)) { - cv_signal(&crp->crp_cv); - } TAILQ_INSERT_TAIL(&crp->fcrp->crp_ret_mq, crp, crp_next); selnotify(&crp->fcrp->sinfo, 0, 0); |
