summaryrefslogtreecommitdiff
path: root/sys
diff options
context:
space:
mode:
authoryamt <yamt@NetBSD.org>2004-01-10 14:52:53 +0000
committeryamt <yamt@NetBSD.org>2004-01-10 14:52:53 +0000
commit5abccc6a0c0a819f60376cccd40b4e37df31d16d (patch)
treefa444c0217b2d4f8501b1c11f77b57ac1d6fb090 /sys
parenta3b2d1879c80b9cac17bc43de3002ee40c9e4584 (diff)
comments in nfs_doio_write.
Diffstat (limited to 'sys')
-rw-r--r--sys/nfs/nfs_bio.c18
1 files changed, 15 insertions, 3 deletions
diff --git a/sys/nfs/nfs_bio.c b/sys/nfs/nfs_bio.c
index 792227b1ad4..10f2ce91588 100644
--- a/sys/nfs/nfs_bio.c
+++ b/sys/nfs/nfs_bio.c
@@ -1,4 +1,4 @@
-/* $NetBSD: nfs_bio.c,v 1.114 2003/12/07 21:15:46 fvdl Exp $ */
+/* $NetBSD: nfs_bio.c,v 1.115 2004/01/10 14:52:53 yamt Exp $ */
/*
* Copyright (c) 1989, 1993
@@ -35,7 +35,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: nfs_bio.c,v 1.114 2003/12/07 21:15:46 fvdl Exp $");
+__KERNEL_RCSID(0, "$NetBSD: nfs_bio.c,v 1.115 2004/01/10 14:52:53 yamt Exp $");
#include "opt_nfs.h"
#include "opt_ddb.h"
@@ -967,7 +967,7 @@ nfs_doio_write(bp, uiop)
boolean_t stalewriteverf = FALSE;
int i, npages = (bp->b_bcount + PAGE_SIZE - 1) >> PAGE_SHIFT;
struct vm_page *pgs[npages];
- boolean_t needcommit = TRUE;
+ boolean_t needcommit = TRUE; /* need only COMMIT RPC */
boolean_t pageprotected;
struct uvm_object *uobj = &vp->v_uobj;
int error;
@@ -991,8 +991,20 @@ again:
* this page belongs to our object.
*/
simple_lock(&uobj->vmobjlock);
+ /*
+ * write out the page stably if it's about to
+ * be released because we can't resend it
+ * on the server crash.
+ *
+ * XXX assuming PG_RELEASE|PG_PAGEOUT won't be
+ * changed until unbusy the page.
+ */
if (pgs[i]->flags & (PG_RELEASED|PG_PAGEOUT))
iomode = NFSV3WRITE_FILESYNC;
+ /*
+ * if we met a page which hasn't been sent yet,
+ * we need do WRITE RPC.
+ */
if ((pgs[i]->flags & PG_NEEDCOMMIT) == 0)
needcommit = FALSE;
simple_unlock(&uobj->vmobjlock);