summaryrefslogtreecommitdiff
path: root/usr.bin/make
diff options
context:
space:
mode:
authorrillig <rillig@NetBSD.org>2021-04-15 18:21:27 +0000
committerrillig <rillig@NetBSD.org>2021-04-15 18:21:27 +0000
commit8afd4a05af27ca11cf1daa163bfd39d9a5a6ef9f (patch)
treeacb5f970676fab18c6e80089cc0108cbf701f3a4 /usr.bin/make
parentf34ac5778aaae9388bc9e2906c6dc34549e1d343 (diff)
make: document two previously unknown bugs in job mode
Diffstat (limited to 'usr.bin/make')
-rw-r--r--usr.bin/make/job.c14
1 files changed, 11 insertions, 3 deletions
diff --git a/usr.bin/make/job.c b/usr.bin/make/job.c
index 37b02c32444..a6462aad358 100644
--- a/usr.bin/make/job.c
+++ b/usr.bin/make/job.c
@@ -1,4 +1,4 @@
-/* $NetBSD: job.c,v 1.424 2021/04/04 10:05:08 rillig Exp $ */
+/* $NetBSD: job.c,v 1.425 2021/04/15 18:21:27 rillig Exp $ */
/*
* Copyright (c) 1988, 1989, 1990 The Regents of the University of California.
@@ -142,7 +142,7 @@
#include "trace.h"
/* "@(#)job.c 8.2 (Berkeley) 3/19/94" */
-MAKE_RCSID("$NetBSD: job.c,v 1.424 2021/04/04 10:05:08 rillig Exp $");
+MAKE_RCSID("$NetBSD: job.c,v 1.425 2021/04/15 18:21:27 rillig Exp $");
/*
* A shell defines how the commands are run. All commands for a target are
@@ -1834,7 +1834,9 @@ again:
break;
} else if (job->outBuf[i] == '\0') {
/*
- * Why?
+ * FIXME: The null characters are only replaced with
+ * space in the last line. Everywhere else they hide
+ * the rest of the command output.
*/
job->outBuf[i] = ' ';
}
@@ -1866,6 +1868,12 @@ again:
if (i >= job->curPos) {
char *cp;
+ /*
+ * FIXME: SwitchOutputTo should be here, according to
+ * the comment above. But since PrintOutput does not
+ * do anything in the default shell, this bug has gone
+ * unnoticed until now.
+ */
cp = PrintOutput(job->outBuf, &job->outBuf[i]);
/*