summaryrefslogtreecommitdiff
path: root/usr.bin/mail
AgeCommit message (Collapse)Author
2023-06-03bsd.own.mk: rename GCC_NO_* to CC_WNO_*lukem
Rename compiler-warning-disable variables from GCC_NO_warning to CC_WNO_warning where warning is the full warning name as used by the compiler. GCC_NO_IMPLICIT_FALLTHRU is CC_WNO_IMPLICIT_FALLTHROUGH Using the convention CC_compilerflag, where compilerflag is based on the full compiler flag name.
2022-08-30etc: Fix permissions of various editable configuration files.riastradh
This way they match the mtree and make sense and don't cause editors to ask to override read-only files when editing them. Exception: Not sure /etc/bluetooth/protocols makes as much sense to edit, but the mtree says 644, so if you want to change it, make sure to change it in both places -- Makefile and mtree. XXX pullup-8 XXX pullup-9
2022-08-07fix some typos and grammar in comments.andvar
2022-08-06s/blity/bility/ in various words, mainly in comments.andvar
2022-05-28fix various typos, mainly in comments.andvar
2021-12-17Remove an unnecessary test for NULL (the same thing is done in thekre
following lines) along with an incorrect return of nothing if it is found (the following version correctly returns NULL). Should unbreak build.
2021-12-17more protection from unset threads from RVPchristos
2021-12-14Avoid NULL deref if there is no current thread. From RVP.christos
Prints "No applicable message"
2021-12-14PR/56548: RVP: mail(1) segfaults if thread commands are used in ~/.mailrcchristos
2021-12-07fix various typos, mainly in comments.andvar
2021-11-27usr.bin: remove unnecessary CONSTCOND, lint no longer needs itrillig
Since 2021-01-31, lint no longer requires a CONSTCOND comment in a do-while-0 statement since this is a common code pattern, especially in statement-like macros.
2021-11-10s/struture/structure/ in comment.msaitoh
2021-11-01mail.1: fix duplicate wordrillig
2021-09-10usr.bin: remove unnecessary lint comment CONSTCONDrillig
Since 2021-01-31, lint no longer warns about 'do ... while (0)'. No functional change.
2021-04-19Fix weekday parsing; only reset the string when parsing fail and only setchristos
the weekday when parsing succeeds (Steffen Nurpmeso)
2021-02-17add O_CLOEXECchristos
2019-12-17fix sun2christos
2019-12-16revert previous, don't specialcase NUL string.christos
2019-12-15treat empty variables are unset (Steffen Nurpmeso)christos
2019-12-14PR/54764: elo: Incorrect '+file' filename completion in mail(1)christos
Add propel completion stem so that file completion works. pullup-9
2019-12-14PR/54765: elo: Minor error in the mail(1) man page (-F description truncated)christos
pullup-9
2019-12-14PR/54766: elo: Broken mime-hooks handling in mail(1)christos
pullup-9.
2019-10-24Switch the iconv(3) prototype to the POSIX conformant variationkamil
Remove const from the 2nd argument. const char ** and char ** are incompatible types and it was a cost to keep the technically incompatible form for a more purist variation. NetBSD was almost the last alive OS to still keep the const argument (known leftovers: Minix and Illumos). Keep the const form for the internal purposes inside citrus and rump. Address the build breakage fallout in the same change. There are no ABI changes. Change accepted by core@.
2019-10-13introduce some common variables for use in GCC warning disables:mrg
GCC_NO_FORMAT_TRUNCATION -Wno-format-truncation (GCC 7/8) GCC_NO_STRINGOP_TRUNCATION -Wno-stringop-truncation (GCC 8) GCC_NO_STRINGOP_OVERFLOW -Wno-stringop-overflow (GCC 8) GCC_NO_CAST_FUNCTION_TYPE -Wno-cast-function-type (GCC 8) use these to turn off warnings for most GCC-8 complaints. many of these are false positives, most of the real bugs are already commited, or are yet to come. we plan to introduce versions of (some?) of these that use the "-Wno-error=" form, which still displays the warnings but does not make it an error, and all of the above will be re-considered as either being "fix me" (warning still displayed) or "warning is wrong."
2019-09-01Remove superfluous Pp.wiz
2019-09-01mail was in v1sevan
https://www.bell-labs.com/usr/dmr/www/man12.pdf
2019-07-26PR/54410: fmoon: typos in mail(1)christos
2019-02-01compare pointers with NULL not '\0'.mrg
2018-06-10use SUBDIR.roff suggested by uwe@christos
2018-05-23Remove Mailchristos
2018-02-04fixes for GCC 6.4:mrg
mail's execute() needs a volatile for setjmp(). telnet has a missing {} issue. isdnd's print_config() has a missing/wrong {} issue, and its p_q931bc() has inconsistent indentation (but not any actual problem.) map-mbone's accept_neighbors2() compares a vs. a instead of a vs. b. sysinst's pm_cgd_check() has missing {} issue. timed's main() has missing {} issue.
2017-11-09Only open regular files.christos
2017-07-03Remove workaround for ancient HTML generation code.wiz
2017-05-02reset signal handler before returning.christos
2017-01-23Fix spelling: s/overritten/overwrittenabhinav
2016-09-05Drop main() prototype.sevan
2016-02-03PR/50746: David Binderman: Check bounds before dereferencing.christos
2015-11-25PR/50360: Thomas Klausner: Fix MKREPRO issuechristos
2015-07-04fix infinite loopchristos
2015-07-04If we fail 5 times in a row, fail correctly (Steffen Nurpmeso).christos
2015-06-17one more stray \nchristos
2015-01-10fix wordexp result handlingchristos
2015-01-10fix incorrect arg size computationchristos
2014-12-16Fix various security related issues:christos
0001. Do not recognize paths, mail folders, and pipes in mail addresses by default. That avoids a direct command injection with syntactically valid email addresses starting with |. Such addresses can be specified both on the command line, the mail headers (with -t) or in address lines copied over from previous while replying. This was assigned CVE-2014-7844 for some versions of BSD mailx. It is documented behavior for Heirloom mailx, and was mentioned in an old technical report about BSD mailx (which does not usually make its way into operating system installations). The patch switches off this processing and updates the documentation. Added expandaddr option to explicitly enable this behavior. 0002. When invoking sendmail, prevent option processing for email address arguments. This prevents changing e.g. the Postfix configuration file in unexpected ways. This behavior was documented for BSD mailx (sort of), but not for Heirloom mailx. We did not assign a CVE to this because it is more of a missing feature, and code invoking mailx needs adjustment in the caller as well. Fixed. 0003. Make wordexp support mandatory. (No functional change.) Fixed (replaced explicit shell pipe implementation). 0004. Prevent command execution in the expand function, which is IMHO unexpected. (Not really required with patch 1, and there is still information disclosure/DoS potential if this expansion occurs.) This is a historic vulnerability already fixed in the Debian package, retroactively assigned CVE-2004-2771: Fixed (as part of the pipe replacement with wordexp).
2014-10-18src is too big these days to tolerate superfluous apostrophes. It'ssnj
"its", people!
2014-10-01put back ua will fix differently.christos
2014-09-30There is no \(ua in roff, you really mean \(ha (Circumflex-Accent) aka ^christos
2014-07-05Reorg docs, part 1:dholland
Move all the reference manuals to subdirs of /usr/share/doc/reference. We have subdirs ref1-ref9, corresponding to man page sections 1-9. Everything that's the reference manual for a program (sections 1, 6, 8), C interface (sections 2, 3), driver or file system (section 4), format or configuration (section 5), or kernel internal interface (section 9) belongs in here. Section 7 is a little less clear: some things that might go in section 7 if they were a man page aren't really reference manuals. So I'm only putting things in reference section 7 that are (to me) clearly reference material, rather than e.g. tutorials, guides, FAQs, etc. This obviously leaves some room for debate, especially without first editing the docs with this distinction in mind, but if people hate what I've done things can always be moved again. Note also that while roff macro man pages traditionally go in section 7, I have put all the roff documentation (macros, tools, etc.) in one place in reference/ref1/roff. This will make it easier to find and also easier to edit it into some kind of coherent form.
2014-07-05Rework /usr/share/doc.dholland
Update the <bsd.doc.mk> infrastructure, and update the docs to match the new infrastructure. - Build and install text, ps, pdf, and/or html, not roff sources. - Don't wire the chapter numbers into the build system, or use them in the installed pathnames. This didn't matter much when the docs were a museum, but now that we're theoretically going to start maintaining them again, we're going to add and remove documents periodically and having the chapter numbers baked in creates a lot of thrashing for no purpose. - Specify the document name explicitly, rather than implicitly in a path. Use this name (instead of other random strings) as the name of the installed files. - Specify the document section, which is the subdirectory of /usr/share/doc to install into. - Allow multiple subdocuments. (That is, multiple documents in one output directory.) - Enumerate the .png files groff emits along with html so they can be installed. - Remove assorted hand-rolled rules for running roff and roff widgetry and add enough variable settings to make these unnecessary. This includes support for - explicit use of soelim - refer - tbl - pic - eqn - Forcibly apply at least minimal amounts of sanity to certain autogenerated roff files. - Don't exclude USD.doc, SMM.doc, and PSD.doc directories from the build, as they now actually do stuff. Note: currently we can't generate pdf. This turns out to be a nontrivial problem with no immediate solution forthcoming. So for now, as a workaround, install compressed .ps as the printable form.
2013-10-18fix unused variable warningschristos