summaryrefslogtreecommitdiff
path: root/usr.bin/make/unit-tests/moderrs.exp
AgeCommit message (Collapse)Author
2021-06-21tests/make: remove unnecessary -dL from moderrs.mkrillig
It was only needed for the test for unmatched subexpressions in the modifier ':C'. That test has been moved to varmod-subst-regex.mk.
2021-06-21tests/make: move and extend test for unmatched '\1' in ':C'rillig
This test lived together with a few unrelated tests in moderrs.mk, it is better placed in varmod-subst-regex.mk though. While here, extend, document and explain the test since its purpose was not obvious from reading the code alone.
2021-06-21Do not report unmatched regex subexpressionssjg
It is not always an error for a subexpression to have not matched, since the regex library can/does not convey how many matches are expected, only report an error if opts.strict (-dL) Reviewed by: christos
2021-02-23make: improve error message for bad modifier in variable expressionrillig
The improvement is especially noteable for variable expressions based on the empty variable, see moderrs.exp:103.
2021-02-23make: add test for confusing error message for bad modifierrillig
In the expression ${:U}, the variable name is empty. Since these expressions are generated by .for loops, the error messages for them must not end with a trailing space. Putting the variable name in quotes helps against that.
2021-02-23make: improve error message for unclosed modifierrillig
Replace "variable specification" with the more modern "variable expression", reduce the number of parentheses, output more than a single character for modifiers, make it obvious that in expressions such as ${:Serror}, the "" means a variable name.
2021-02-23make: improve error message for unknown modifierrillig
Back in 1995, the modifiers were all single-character, and it made sense to print only the first character. Nowadays, with ':S', ':@var@...@', '::=' and several others, a little more context is useful to see where the exact error is. The actual modifier is still guessed, and the guess may be wrong as soon as backslashes get involved, but it is still better than before.
2021-02-23make: quote ':S' in error message about missing delimiterrillig
2021-02-23make: add quotes around variable name in an error messagerillig
2020-11-01make(1): treat malformed :range, :ts and :[...] as errorsrillig
Before, integer overflow in the :[1..2] modifier had not been detected, and the actual behavior varied between ILP64 and LP64I32 machines. Before, the :ts modifier accepted character literals like \012345 and \x1F600, which don't fit in a single character and were thus truncated. Before, the :range modifier issued an "Unknown modifier" error message for :range=x, which was not quite correct. The error message in this case is now "Invalid number".
2020-11-01make(1): demonstrate parsing bugs in test moderrs.mkrillig
When a malformed variable expression is parsed, the remaining part of the expression is passed unmodified to the output. This is unexpected and wrong.
2020-11-01make(1): renumber the tests in moderrs.mk, remove duplicatesrillig
2020-11-01make(1): make test names in moderrs.mk more descriptiverillig
2020-11-01make(1): precisely describe the expected output in the test moderrs.mkrillig
By making "want:" the same length as "make:", the remaining text in these lines can be compared easily.
2020-11-01make(1): separate sections of moderrs.mk with empty linesrillig
2020-11-01make(1): add section headings to the test moderrs.mkrillig
2020-08-25make(1): move test for the ::= modifier to varmod-assignrillig
2020-08-09make(1): improve test for undefined subexpression in :C modifierrillig
In the previous test output, it was unnecessarily hard to see what happens because of the many empty strings. Enclosing the capturing groups in parentheses helps against this.
2020-08-09make(1): add test for undefined subexpression in the :C modifierrillig
2020-08-08make(1): improve error message in case of unfinished modifiersrillig
The previous error message "Unclosed substitution" was wrong for several reasons. It is not about "unclosed", but about "unfinished" since in the :@var@...@ modifier the missing '@' does not really close anything. The word "substitution" may have originated in a time where :S and :from=to were the only modifiers, and these were indeed substitutions, but several other modifiers aren't. The :S and :C modifiers allow an arbitrary delimiter, therefore it is helpful to enclose the delimiter in quotes, just in case someone chooses ')' or '{' or even ' ' as delimiter.
2020-07-31make(1): add test for parsing an incomplete :t modifierrillig
This looks a lot like undefined behavior, just like in :S and :C before.
2020-07-31make(1): fix undefined behavior when parsing malformed :C modifierrillig
Same as in the :S modifier.
2020-07-31make(1): fix undefined behavior in malformed :S modifierrillig
The unit tests failed on Ubuntu, and by looking closely at the code, it was trivial to see the out-of-bounds memory read. Other modifiers may have the same problem and will be inspected later.
2020-07-29make(1): fix segfault when evaluating ${::=value}rillig
The bug had been in the handling of the SysV modifier for many years, but it had not been triggered since the "parsing position for the next modifier" had been initialized to a non-NULL pointer. In var.v r1.350, this pointer had been initialized to NULL instead since every ApplyModifier function must set it in every case where it returns anything except "default_case". There might have been a slight chance of tricking make to output a wrong error message, but nothing worse.
2020-07-29make(1): add enough tests to cover the ApplyModifier functionsrillig
Only a few return statements are still missing from the code coverage. In ApplyModifier_Assign, the test for an empty variable name is skipped for now since it segfaults. In ApplyModifier_SysV after the second ParseModifierPart, the branch for the missing delimiter is not reached since this case is already checked for in the first part of the function. To trigger this branch, a specially crafted, unrealistic string needs to be created, and that's too complicated for the moment.
2020-07-29make(1): add unit tests for parse errors in modifiersrillig
2020-07-28make(1): add test for modifier part with unbalanced bracesrillig
2020-07-26make(1): add tests for :!...! parse errorsrillig
2020-07-26make(1): add test for missing input validation in :[123] modifierrillig
2020-07-26make(1): fix missing error message about missing @ delimiterrillig
This had been broken since 2020-07-03, during a "refactoring".
2020-07-26make(1): add test about missing delimiters in :@ modifierrillig
These error conditions have been broken since var.c 1.236 on 2020-07-03.
2014-08-21Give each group of tests its own output file.apb
* Rename each sub-makefile to *.mk; * Add a *.exp file of expected output for each sub-makefile; * Remove test.exp, which is replaced by all the other *.exp files. * Use suffix rules to generate *.rawout and *.out files for each test case. * Rewrite the test and accept targets to adapt to the new way. The old (now removed) test.exp file is almost identical to the concatenation (in the correct order) of all the new *.exp files. There are expected differences in makefile names embedded in the output, and the new "exit status" lines. Some old "*** Error code 1 (ignored)" lines are also removed (replaced by new "exit status 1" lines).