summaryrefslogtreecommitdiff
path: root/usr.sbin/mrouted
AgeCommit message (Collapse)Author
2023-06-03bsd.own.mk: rename GCC_NO_* to CC_WNO_*lukem
Rename compiler-warning-disable variables from GCC_NO_warning to CC_WNO_warning where warning is the full warning name as used by the compiler. GCC_NO_IMPLICIT_FALLTHRU is CC_WNO_IMPLICIT_FALLTHROUGH Using the convention CC_compilerflag, where compilerflag is based on the full compiler flag name.
2023-06-03bsd.own.mk: rename to CC_WNO_ADDRESS_OF_PACKED_MEMBERlukem
Provide a single variable CC_WNO_ADDRESS_OF_PACKED_MEMBER with options for both clang and gcc, to replace CLANG_NO_ADDR_OF_PACKED_MEMBER CC_NO_ADDR_OF_PACKED_MEMBER GCC_NO_ADDR_OF_PACKED_MEMBER Using the convention CC_compilerflag, where compilerflag is based on the full compiler flag name.
2020-09-07change cksum prototype to const void *, and check alignment via assertion.christos
2020-09-06add support for new GCC 9 warnings that may be too much to fixmrg
right now. new address-of-packed-member and format-overflow warnings have new GCC_NO_ADDR_OF_PACKED_MEMBER amd GCC_NO_FORMAT_OVERFLOW variables to remove these warnings. apply to a bunch of the tree. mostly, these are real bugs that should be fixed, but in many cases, only by removing the 'packed' attribute from some structure that doesn't really need it. (i looked at many different ones, and while perhaps 60-80% were already properly aligned, it wasn't clear to me that the uses were always coming from sane data vs network alignment, so it doesn't seem safe to remove packed without careful research for each affect struct.) clang already warned (and was not erroring) for many of these cases, but gcc picked up dozens more.
2019-10-13introduce some common variables for use in GCC warning disables:mrg
GCC_NO_FORMAT_TRUNCATION -Wno-format-truncation (GCC 7/8) GCC_NO_STRINGOP_TRUNCATION -Wno-stringop-truncation (GCC 8) GCC_NO_STRINGOP_OVERFLOW -Wno-stringop-overflow (GCC 8) GCC_NO_CAST_FUNCTION_TYPE -Wno-cast-function-type (GCC 8) use these to turn off warnings for most GCC-8 complaints. many of these are false positives, most of the real bugs are already commited, or are yet to come. we plan to introduce versions of (some?) of these that use the "-Wno-error=" form, which still displays the warnings but does not make it an error, and all of the above will be re-considered as either being "fix me" (warning still displayed) or "warning is wrong."
2019-02-03- add or adjust /* FALLTHROUGH */ where appropriatemrg
- add __unreachable() after functions that can return but won't in this case, and thus can't be marked __dead easily
2017-07-03Remove workaround for ancient HTML generation code.wiz
2015-02-05Fix bug in mrouted about aging neighbors.gdt
mrouted will periodically age its neighbors and will remove a neighbor if it hasn't heard from it for NEIGHBOR_EXPIRE_TIME. Unfortunately, the neighbor pointers 'a' and 'prev_a' were never advanced when timer was not expired. Therefore it would get stuck in a tight loop, advancing 'al_timer' until it would be greater than NEIGHBOR_EXPIRE_TIME. This caused the neighbor to allways get timed out and dropped. Furthermore, there was a second bug in this loop when deleting an item that was not at the head of the list (i.e., prev_a should stay the same instead of advancing). This bug fix is the work of Konrad Lorincz. Bug found and fix made on netbsd-6. This material is based upon work supported by the Defense Advanced Research Projects Agency and Space and Naval Warfare Systems Center, Pacific, under Contract No. N66001-09-C-2073. Any opinions, findings and conclusions or recommendations expressed in this material are those of the author(s) and do not necessarily reflect the views of the Defense Advanced Research Project Agency and Space and Naval Warfare Systems Center, Pacific. Approved for Public Release, Distribution Unlimited
2011-08-31NULL does not need a castplunky
2011-08-31Use __deadjoerg
2011-05-26Default to -Wno-sign-compare -Wno-pointer-sign for clang.joerg
Push -Wno-array-bounds down to the cases that depend on it. Selectively disable warnings for 3rd party software or non-trivial issues to be reviewed later to get clang -Werror to build most of the tree.
2011-02-23Don't use bool as a variable name.dyoung
Remove a bunch of parameter names form function prototypes.
2009-04-17Fix WARNS=4 (-Wshadow -Wsign-compare -Wcast-qual)lukem
2009-03-15Fix markup.joerg
2008-08-26- Clean up warnings / errors.seanb
2007-05-28Add new Makefile knob, USE_FORT, which extends USE_SSP by turning on thetls
FORTIFY_SOURCE feature of libssp, thus checking the size of arguments to various string and memory copy and set functions (as well as a few system calls and other miscellany) where known at function entry. RedHat has evidently built all "core system packages" with this option for some time. This option should be used at the top of Makefiles (or Makefile.inc where this is used for subdirectories) but after any setting of LIB. This is only useful for userland code, and cannot be used in libc or in any code which includes the libc internals, because it overrides certain libc functions with macros. Some effort has been made to make USE_FORT=yes work correctly for a full-system build by having the bsd.sys.mk logic disable the feature where it should not be used (libc, libssp iteself, the kernel) but no attempt has been made to build the entire system with USE_FORT and doing so will doubtless expose numerous bugs and misfeatures. Adjust the system build so that all programs and libraries that are setuid, directly handle network data (including serial comm data), perform authentication, or appear likely to have (or have a history of having) data-driven bugs (e.g. file(1)) are built with USE_FORT=yes by default, with the exception of libc, which cannot use USE_FORT and thus uses only USE_SSP by default. Tested on i386 with no ill results; USE_FORT=no per-directory or in a system build will disable if desired.
2007-02-21Move ctype.h header from defs.h to main.c where it's really usedhubertf
From: Slava Semushin <slava.semushin@gmail.com>
2006-05-25Coverity CID 1188: Don't check for NULL just to log and then diechristos
de-referencing; return instead.
2006-05-25Coverity CID 1189, 1190: Don't check for NULL just to log and then diechristos
de-referencing; return instead.
2006-05-25Coverity CID 1191, 1192: Don't check for NULL allocation, just to log itchristos
and then die dereferencing. Return instead.
2006-05-25Coverity CID 2718: Avoid using free'd memory.christos
2006-05-12can't fit "256" in an 8bit value, don't have a switch case for it.mrg
2006-05-11if we are going to cast the 3rd argument to accept_info_request(),mrg
use the right type.
2006-05-09change (mostly) int to socklen_t. GCC 4 doesn't like that int andmrg
socklen_t are different signness.
2004-10-30Add (unsigned char) cast to ctype functionsdsl
2003-09-07Consistently use 'RFC 1234' instead of 'RFC1234' or 'RFC-1234'.wiz
From jmc@openbsd.
2003-09-06use arc4randomitojun
2003-08-18SIOCGIFCONF -> getifaddrs conversionitojun
2003-07-13strdup is simpleritojun
2003-05-17remove obsolete commentitojun
2003-05-17A slightly better inet_parse(), tested in isolation.dsl
2003-05-16Revert previous change. Remove s parameter from teh function and rotatedsl
the result through a fixed set of strings instead. There never was a possibility of a buffer overrun in inet_fmt{s}(). Fix an actual buffer overrun in a scanf() call.
2003-05-16avoid possible buffer overruns - strlcpy, snprintfitojun
2003-03-07This seems to need a -I${.CURDIR} these days.fvdl
2003-03-05Add RCS Id; new sentence, new line; at least one mdoc fix; sort sections.wiz
2003-03-05mdocified man page from mpech@openbsd.orgwiz
2003-03-05ANSIfy one more.wiz
2003-03-05Use vsnprintf instead of vsprintf. From OpenBSD.wiz
2003-03-05Add license (from Xerox), from OpenBSD.wiz
2003-03-05License update from Stanford, via OpenBSD.wiz
2003-03-05Move back from gnu/dist/mrouted, now that it's available under a BSDwiz
license.
2002-10-01move mrouted out of basesrc, as it carries non-BSD license.itojun
agreed w/ core.
2002-08-09die if fd_set overrun. (they're not setuid binary so it is not that critical)itojun
2002-08-01ifa->ifa_addr is already pointer, no need for "&". from loveitojun
2002-08-01use getifaddrs, not SIOCGIFCONF. should fix PR12578itojun
2002-08-01avoid issues with typecast optimization (taking advantage of pointer aliasing),itojun
which results in incorrect igmp checksum. confirmed by taca@netbsd
2002-08-01u_short cleansing (should be u_int16_t)itojun
2002-07-14Unifdef __STDC__. Remove __P(). Remove register. ANSIfy.wiz
2002-06-02missing memset() for sockaddr. from deraadtitojun
2002-02-08Generate <>& symbolically. I'm avoiding .../dist/... directories for now.ross