summaryrefslogtreecommitdiff
path: root/sys/miscfs
diff options
context:
space:
mode:
authorriastradh <riastradh@NetBSD.org>2022-03-28 12:37:35 +0000
committerriastradh <riastradh@NetBSD.org>2022-03-28 12:37:35 +0000
commit5b0334cb548083ee3e9beb34d51fd9a8c5df8759 (patch)
tree1cee2aa8f7a784a3bcd38a323030ba4a1b30a4a2 /sys/miscfs
parentf0bfccf00b94619120a00a10bfbe375246c9d76f (diff)
specfs: Assert opencnt is nonzero before decrementing.
Diffstat (limited to 'sys/miscfs')
-rw-r--r--sys/miscfs/specfs/spec_vnops.c8
1 files changed, 6 insertions, 2 deletions
diff --git a/sys/miscfs/specfs/spec_vnops.c b/sys/miscfs/specfs/spec_vnops.c
index 109785a176b..0df5a57b3ca 100644
--- a/sys/miscfs/specfs/spec_vnops.c
+++ b/sys/miscfs/specfs/spec_vnops.c
@@ -1,4 +1,4 @@
-/* $NetBSD: spec_vnops.c,v 1.206 2022/03/28 12:37:26 riastradh Exp $ */
+/* $NetBSD: spec_vnops.c,v 1.207 2022/03/28 12:37:35 riastradh Exp $ */
/*-
* Copyright (c) 2008 The NetBSD Foundation, Inc.
@@ -58,7 +58,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: spec_vnops.c,v 1.206 2022/03/28 12:37:26 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: spec_vnops.c,v 1.207 2022/03/28 12:37:35 riastradh Exp $");
#include <sys/param.h>
#include <sys/proc.h>
@@ -944,6 +944,8 @@ spec_open(void *v)
KASSERT(sn->sn_opencnt == 1);
needclose = true;
} else {
+ KASSERT(sd->sd_opencnt);
+ KASSERT(sn->sn_opencnt);
sd->sd_opencnt--;
sn->sn_opencnt--;
if (vp->v_type == VBLK)
@@ -1643,6 +1645,8 @@ spec_close(void *v)
* between open and close can use fd_clone.
*/
mutex_enter(&device_lock);
+ KASSERT(sn->sn_opencnt);
+ KASSERT(sd->sd_opencnt);
sn->sn_opencnt--;
count = --sd->sd_opencnt;
if (vp->v_type == VBLK) {